Add a plugin for column-resizing #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And preserve it when modifying colspan
That takes care of populating and updating the <col> tags and the table's min width.
Move table node view into columnResizing plugin
|
(Updated to no longer include c3c448e, which was merged into master.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request does several things:
It add an attribute
colwidthto table cells, which stores the width of the columns that the cell if part of. Each column can have either no fixed with or a width in pixels.I ended up storing this on the cells instead of the table because it makes it easier to make sure that a given width 'sticks' to the right column when the table is modified, and when cells are moved around. The table-fixing code makes sure column widths stay coherent by adjusting widths in the same column to the width of the majority of that column
It introduces a new plugin
columnResizingwhich implements a table view that renders and updates<col>tags for tables to specify the column widths, and functionality for resize handles on column boundaries.(I ended up including the patch from #10 in this because untangling it caused some conflicts. If that one is rejected, I'll update this branch to remove it.)