Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix types for cellSelection #160

Merged
merged 5 commits into from
Jul 19, 2022
Merged

Fix types for cellSelection #160

merged 5 commits into from
Jul 19, 2022

Conversation

MH4GF
Copy link
Contributor

@MH4GF MH4GF commented Jan 28, 2022

Closes #159

@MH4GF
fix types for cellSelection
c71e706 
Closes ProseMirror#159
@MH4GF
add CellBookmark interface
ab1381c 
because getBookmark() does not imprements Selection's type
@MH4GF
Copy link
Contributor Author

MH4GF commented Jul 19, 2022 •
edited
Loading

Hi @ocavue , thanks for restarting maintenance.
I am having trouble with CellSelection not applying to setSelection() and would like to incorporate this patch.
I have imported the latest master branch and would like you to review it.

@MH4GF MH4GF mentioned this pull request Jul 19, 2022
Closed
ocavue
ocavue approved these changes Jul 19, 2022
View reviewed changes
Copy link
Collaborator

@ocavue ocavue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ocavue ocavue merged commit c8aa83b into ProseMirror:master Jul 19, 2022
@MH4GF MH4GF mentioned this pull request Jul 20, 2022
Closed
MH4GF added a commit to MH4GF/prosemirror-tables that referenced this pull request Jul 20, 2022
@MH4GF
fix CellBookmark typings
e124dce 
ProseMirror#160
The CellBookmark type added here was incorrect and the following error is fixed.

```
index.ts:25:43 - error TS2322: Type 'CellSelection' is not assignable to type 'Selection'.
  The types of 'getBookmark().map' are incompatible between these types.
    Type '(mapping: Mapping) => CellBookmark' is not assignable to type '(mapping: Mappable) => SelectionBookmark'.
      Types of parameters 'mapping' and 'mapping' are incompatible.
        Type 'Mappable' is missing the following properties from type 'Mapping': maps, from, to, slice, and 5 more.

1      let state = EditorState.create({ doc, selection: CellSelection.create(table, 0) });
```
MH4GF added a commit to MH4GF/prosemirror-tables that referenced this pull request Jul 20, 2022
@MH4GF
fix CellBookmark typings
39d2bdd 
ProseMirror#160
The CellBookmark type added here was incorrect and the following error is fixed.

```
index.ts:25:43 - error TS2322: Type 'CellSelection' is not assignable to type 'Selection'.
  The types of 'getBookmark().map' are incompatible between these types.
    Type '(mapping: Mapping) => CellBookmark' is not assignable to type '(mapping: Mappable) => SelectionBookmark'.
      Types of parameters 'mapping' and 'mapping' are incompatible.
        Type 'Mappable' is missing the following properties from type 'Mapping': maps, from, to, slice, and 5 more.

1      let state = EditorState.create({ doc, selection: CellSelection.create(table, 0) });
```
@MH4GF MH4GF mentioned this pull request Jul 20, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinmelo kevinmelo kevinmelo approved these changes

@ocavue ocavue ocavue approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CellSelection is extends Selection, but typescript definitions are not extends it
3 participants
@MH4GF @kevinmelo @ocavue