fix CellBookmark typing #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ProseMirror#160 The CellBookmark type added here was incorrect and the following error is fixed. ``` index.ts:25:43 - error TS2322: Type 'CellSelection' is not assignable to type 'Selection'. The types of 'getBookmark().map' are incompatible between these types. Type '(mapping: Mapping) => CellBookmark' is not assignable to type '(mapping: Mappable) => SelectionBookmark'. Types of parameters 'mapping' and 'mapping' are incompatible. Type 'Mappable' is missing the following properties from type 'Mapping': maps, from, to, slice, and 5 more. 1 let state = EditorState.create({ doc, selection: CellSelection.create(table, 0) }); ```
MH4GF
commented
Jul 20, 2022
| EditorState.create({ | ||
| doc: table, | ||
| selection: CellSelection.create(table, 0), | ||
| }); |
There was a problem hiding this comment.
I added it to the test, but currently test-typescript.js is not working correctly.
Here's the PR we're going to fix: #177
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#160
The CellBookmark type added here was incorrect and the following error is fixed.