-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support prioritization of actions / groups #236
Comments
I really like the idea of using Groups to manage priority vs using hooks. 💯 Subscriptions doesn't use groups (yet), so existing stores using wouldn't benefit from that. We can change that easily enough though for future actions. We can also make sure webhooks and WC Admin, which are using groups, use a priority > the default as well so that subscription actions are still run.
That sounds like a smart approach to me. |
I support this implementation. Thoughts - when you have something like the high volume plugin running and you're running multiple "threads"... the ability to specify some of those threads to specific groups/queues would be interesting. In a case like this where there is infrastructure to support it, having dedicated subscription threads and dedicated wc admin threads / etc could be useful. I'm sure the WP CLI commands will support running against specific groups though so maybe that will be enough. Our large sites we run cron via WP CLI anyways for a variety of reasons. |
@pmgarman Thanks, good suggestions. Adding group support to the high volume plugin could probably be added to that plugin independently of the changes happening here. Currently, the WP CLI command only supports a single group but adding support for multiple groups would be a nice enhancement. |
Closing this as we haven't seen a situation with 3.X where this was needed. |
In the WC #core chat there was some discussion about expanding the capabilities of Action Scheduler around the increasing number of scheduled tasks.
The WooCommerce Admin plugin uses scheduled tasks to maintain lookup & statistical tables for the new dashboard. They have asked that we look into implementing queuing/groups and/or a priority system.
After some discussion with @thenbrent and reviewing the current codebase & custom tables plugin, I have the following proposal for discussion:
10
as the default priority (consistent with WP hook priority)-- programatic registration
-- user defined via the dashboard
-- default priority for the group
The text was updated successfully, but these errors were encountered: