Ensure "Isotope Dist Proportion" has the correct value for newly added small molecule transition #2587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d small molecule transition Fixed incorrect isotope dot product for newly imported small molecule precursor transition (reported by Noortje)
|
I agree, that seems like a lot of local and probably duplicated code for something that presumably ought to happen whenever such a node is created. Could there be a common wrapper? And are there other places where that wrapper ought to be employed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed incorrect isotope dot product for newly imported small molecule precursor transition (reported by Noortje)
There might be a better way to fix this involving sharing code for creating transitions between SmallMoleculeTransitionListReader and TransitionGroupDocNode.