Skyline: Include process output in ProcessRunner exceptions when it…

[brendanx67]

…would otherwise be lost

• for diagnosing method export failures

[brendanx67]

Not sure we will merge this to master, but it may be useful in diagnosing a current support request on a failure exporting Waters methods.

[brendanx67]

I think we could merge this now. It puts the output into a nested IOException so that the message doesn't change but the output is available if the user clicks More Info. One thing I am unsure about is that I did this only for IOException, since I didn't want to write another WrapAndThrowException and I didn't want to lose the exception type in the throw that wraps the exception.

[nickshulman]

Looks good to me.

It's unfortunate that the way "CommandLine.ExportInstrumentFile" is currently written, it will catch IOException and throw away this new extra information:

            catch (IOException x)
            {
                _out.WriteLine(Resources.CommandLine_ExportInstrumentFile_Error__The_file__0__could_not_be_saved___Check_that_the_specified_file_directory_exists_and_is_writeable_, args.ExportPath);
                _out.WriteLine(x.Message);
                return false;
            }

[nickshulman]

I would probably catch all exception types here, and not worry about the fact that the type of the exception might be getting changed to IOException from whatever its original type might have been.
But this way is fine too.

[brendanx67]

Okay. That makes sense. I was thinking that catching Exception you would throw Exception, but if you catch exception and throw IOException that seems a bit better to me.

[brendanx67]

Looks good to me.

It's unfortunate that the way "CommandLine.ExportInstrumentFile" is currently written, it will catch IOException and throw away this new extra information:

            catch (IOException x)
            {
                _out.WriteLine(Resources.CommandLine_ExportInstrumentFile_Error__The_file__0__could_not_be_saved___Check_that_the_specified_file_directory_exists_and_is_writeable_, args.ExportPath);
                _out.WriteLine(x.Message);
                return false;
            }

So, you are suggesting that we use _out.WriteLine(x) instead?