Update unimod.xml and UniModData.cs #2763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickshulman
approved these changes
Oct 31, 2023
There was a problem hiding this comment.
Looks good to me.
If we wanted, we could get rid of all of the "PrecisionRequired" stuff.
I think that stuff was added by mistake as part of the high precision bibliospec modification work, but was never actually necessary for the implementation that we eventually ended up going with.
chambm
approved these changes
Oct 31, 2023
…k/20231030_update_unimod
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thermo requested TMTpro be added to our modifications. So, after 10+ years, this is what an update to unimod.xml looks like to make that happen.