Can't Shift-Double-Click Items From Chest

[ghost]

Hello,

I made an issue concerning this exact problem some time ago only to find out the issue had actually been "resolved" or rather, was not occurring at the time. I've received some complaints that the issue was persisting again, this time I decided to reproduce the issue on an isolated "dummy instance" with the latest Spigot and ProtocolSupport build.

With ProtocolSupport:
https://i.imgur.com/SzgmhVp.gif

Without ProtocolSupport:
https://i.imgur.com/HzIzHHW.gif

[MasterDash5]

oh... thats what that was... i thought my anticheat just hated me LOL

but yea, this happens for me too

[krusic22]

ViaVersion fixed this just a little while ago. Might be worth looking at their solution.

[7kasper]

What version's are affected? I cannot reproduce using mc 1.12.2 and latest version of PS and Spigot...

[MasterDash5]

i know 1.8.9 clients and lower are affected

[ghost]

From what I understand this affected all versions 1.8-1.12. ViaVersion wouldn't solve this problem since ViaVersion doesn't work that way, I'm already using 1.12.2 Spigot so obviously, there's nothing to inject there.

[Shevchik]

I guess it's about difference in sent inventory packets. Will look into it when i have time.

[7kasper]

I did notice that wiki.vg says that mode is encoded as VarInt enum, while ProtocolSupport (still) reads and sends it as an unsigned byte.

[Shevchik]

Varint enum and byte has no difference for values < 127.

[dieterblancke]

We also have this problem, it effects any client below 1.12, above it all works.
We're now just telling them to play 1.12 :P.

[UberMC]

I'm shift Double L.Click
https://gyazo.com/07dfca75323423c79d4e2b1e38bfb91b

A lot of players complain about this and it appears to be an important part of minecraft.

[7kasper]

Said this some time ago in discord:

Regarding the inventory double click, as @krusic22 pointed out it was fixed in viaversion ?>(ViaVersion/ViaVersion#754) I suppose we need to delay a packet or two?

In that PR we can see what packets we need to reorder.

[ghost]

Yes please fix this. It's annoying always having to use the latest version of minecraft to shift double click from an inventory.

…

On Wed, May 9, 2018 at 10:20 AM 7kasper ***@***.***> wrote: Said this some time ago in discord. Regarding the inventory double click, as @krusic22 <https://github.com/krusic22> pointed out it was fixed in viaversion ( ViaVersion/ViaVersion#754 <ViaVersion/ViaVersion#754>) I suppose we need to delay a packet or two? In that PR we can see what packets we need to reorder. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#719 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AL_oO_GxzgHzQGqyiPM9QwQCglq6p4Dcks5twwkogaJpZM4P8lZX> .

[linsaftw]

Please fix :(

[FrostNovaHD]

its not that onnoying

[ghost]

I beg to differ, this bug is so annoying that it is the only thing holding me back from using 1.10.2 as my main version of minecraft to play on my server. This annoys so many people on my server; I hope this bug will be fixed soon.

[Shevchik]

Fixed

[TouchBrown]

Fixed

I'm running a 1.12.2 paper server is there a jar with this patch that will work for me

[ghost]

Fixed

I'm running a 1.12.2 paper server is there a jar with this patch that will work for me

Make the same changes as in this commit in a clone of the repository from back when 1.12.2 was supported.
If you are having trouble getting the code from the 1.12 version of the plugin, use the following commands.
git clone https://github.com/ProtocolSupport/ProtocolSupport
cd ProtocolSupport
git checkout a2e767e2211da69177da82cfabb8a2fbd2f79b0b
Then make the same changes as in that commit and then type
./gradlew assemble
I have retired from supporting this project to any meaningful extent and no longer have discord, best of luck to you.

[TouchBrown]

Fixed

I'm running a 1.12.2 paper server is there a jar with this patch that will work for me

Make the same changes as in this commit in a clone of the repository from back when 1.12.2 was supported.
If you are having trouble getting the code from the 1.12 version of the plugin, use the following commands.
git clone https://github.com/ProtocolSupport/ProtocolSupport
cd ProtocolSupport
git checkout a2e767e2211da69177da82cfabb8a2fbd2f79b0b
Then make the same changes as in that commit and then type
./gradlew assemble
I have retired from supporting this project to any meaningful extent and no longer have discord, best of luck to you.

Thank you lots for the help. It looks like this is 1.13 do you know if it will work or if there is another commit that I should checkout

[ghost]

Fixed

I'm running a 1.12.2 paper server is there a jar with this patch that will work for me

Make the same changes as in this commit in a clone of the repository from back when 1.12.2 was supported.
If you are having trouble getting the code from the 1.12 version of the plugin, use the following commands.
git clone https://github.com/ProtocolSupport/ProtocolSupport
cd ProtocolSupport
git checkout a2e767e2211da69177da82cfabb8a2fbd2f79b0b
Then make the same changes as in that commit and then type
./gradlew assemble
I have retired from supporting this project to any meaningful extent and no longer have discord, best of luck to you.

Thank you lots for the help. It looks like this is 1.13 do you know if it will work or if there is another commit that I should checkout

It should work fine, there is a version of the class that was used in the 1.12 version of the plugin, it should have a very similar name. Just make the same changes in that class as was done in the 1.13 class and you should be golden.

[ghost]

My bad the correct tree for 1.12 would be accessible with the following command.
git checkout 6f3b8b878e967d64b03f1a81685ffe2bba54f4a8
Disregard the one in my original comment, I didn't go back far enough when I hastily wrote that comment.
The 1.12 version of the class is src/protocolsupport/protocol/packet/middleimpl/serverbound/play/v_4_5_6_7_8_9r1_9r2_10_11_12r1_12r2/InventoryClick.java
After making the changes type ./gradlew assemble and the jar will be created in target/

[TouchBrown]

Thank you so much for everything I got it working :)