Skip to content

Commit

Permalink
Upgraded Porter to take advantage of importOne().
Browse files Browse the repository at this point in the history
  • Loading branch information
Paul committed Aug 16, 2016
1 parent a8b7bf6 commit 107ea82
Show file tree
Hide file tree
Showing 6 changed files with 25 additions and 32 deletions.
2 changes: 1 addition & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
}
],
"require": {
"scriptfusion/porter": "0.7"
"scriptfusion/porter": "^0.7"
},
"require-dev": {
"phpunit/phpunit": "^4",
Expand Down
14 changes: 7 additions & 7 deletions composer.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

18 changes: 6 additions & 12 deletions test/Functional/CreateChargeTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -11,29 +11,23 @@ final class CreateChargeTest extends PorterTest
{
public function testChargeCard()
{
$results = $this->porter->import(
self::assertValidCharge($this->porter->importOne(
new ImportSpecification(new CreateCharge(TestObjectFactory::createCard(), 1337, 'GBP'))
);

self::assertValidCharge($results->current());
));
}

public function testChargeToken()
{
$results = $this->porter->import(
self::assertValidCharge($this->porter->importOne(
new ImportSpecification(new CreateCharge(TestObjectFactory::createToken(), 1338, 'USD'))
);

self::assertValidCharge($results->current());
));
}

public function testChargeCustomer()
{
$results = $this->porter->import(
self::assertValidCharge($this->porter->importOne(
new ImportSpecification(new CreateCharge(TestObjectFactory::createCustomer(), 1339, 'JPY'))
);

self::assertValidCharge($results->current());
));
}

private static function assertValidCharge(array $charge)
Expand Down
12 changes: 6 additions & 6 deletions test/Functional/CreateCustomerTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -11,16 +11,16 @@ final class CreateCustomerTest extends PorterTest
{
public function testCreateCustomerFromCard()
{
$results = $this->porter->import(new ImportSpecification(new CreateCustomer(TestObjectFactory::createCard())));

self::assertValidCustomer($results->current());
self::assertValidCustomer($this->porter->importOne(
new ImportSpecification(new CreateCustomer(TestObjectFactory::createCard()))
));
}

public function testCreateCustomerFromToken()
{
$results = $this->porter->import(new ImportSpecification(new CreateCustomer(TestObjectFactory::createToken())));

self::assertValidCustomer($results->current());
self::assertValidCustomer($this->porter->importOne(
new ImportSpecification(new CreateCustomer(TestObjectFactory::createToken()))
));
}

private static function assertValidCustomer(array $customer)
Expand Down
6 changes: 3 additions & 3 deletions test/Functional/CreateTokenTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,9 @@ final class CreateTokenTest extends PorterTest
{
public function testCreateToken()
{
$results = $this->porter->import(new ImportSpecification(new CreateToken(TestObjectFactory::createCard())));
$token = $this->porter->importOne(new ImportSpecification(new CreateToken(TestObjectFactory::createCard())));

self::assertArrayHasKey('id', $result = $results->current());
self::assertTrue(Token::isValidIdentifier($result['id']));
self::assertArrayHasKey('id', $token);
self::assertTrue(Token::isValidIdentifier($token['id']));
}
}
5 changes: 2 additions & 3 deletions test/TestObjectFactory.php
Original file line number Diff line number Diff line change
Expand Up @@ -29,15 +29,14 @@ public static function createCard()
public static function createToken()
{
return new Token(
self::createPorter()->import(new ImportSpecification(new CreateToken(self::createCard())))->current()['id']
self::createPorter()->importOne(new ImportSpecification(new CreateToken(self::createCard())))['id']
);
}

public static function createCustomer()
{
return new Customer(
self::createPorter()->import(new ImportSpecification(new CreateCustomer(self::createCard())))
->current()['id']
self::createPorter()->importOne(new ImportSpecification(new CreateCustomer(self::createCard())))['id']
);
}
}

0 comments on commit 107ea82

Please sign in to comment.