Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for node.js v20 [ui] #367

Closed
wants to merge 9 commits into from
Closed

Fix for node.js v20 [ui] #367

wants to merge 9 commits into from

Conversation

slavas490
Copy link
Contributor

@loleg
Copy link
Contributor

loleg commented Oct 10, 2023 •
edited
Loading

I'm not confident about this fix, because the flag is a temporary workaround that leads to various further issues, and seems to be a MacOS problem. In fact our cloud build here is failing for the same reason:

yarn install --cache-folder .yarn
node: --openssl-legacy-provider is not allowed in NODE_OPTIONS
make[1]: *** [Makefile:9: init] Error 9
make[1]: Leaving directory '/home/circleci/project/ui'
make: *** [Makefile:97: ui] Error 2

Please provide some context to your solution @slavas490

@loleg loleg self-requested a review October 10, 2023 14:38
loleg
loleg requested changes Oct 10, 2023
View reviewed changes
Makefile
@@ -71,6 +71,7 @@ dependencies=go curl
mocks=main/handlers/blockchain/mock/adapter_mock.go storage/mock/interfaces.go
bindata=main/handlers/assets/bindata.go test/assets/bindata.go
golocalimport=github.com/ProxeusApp/proxeus-core
uiextraflags=NODE_OPTIONS=--openssl-legacy-provider
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to me that it needs to be a MacOS, Node 17 only fix.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

circleci still running it with 16 node.js

maybe we should update our circleci config to be able to use this flag

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's upgrade CircleCI to 20.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed today, we are probably not quite ready for Node 20.x. I've updated this in #397

@loleg
Copy link
Contributor

loleg commented Nov 6, 2023

Let's close #397 and get back to this after, OK?

@loleg loleg closed this Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loleg loleg loleg requested changes

Assignees
No one assigned
Labels
None yet
Projects
Maintenance - Q1 2024
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@slavas490 @loleg