Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for node.js v20 [ui] #367

Closed
wants to merge 9 commits into from
Closed

Fix for node.js v20 [ui] #367

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
2320ad3
fix radio and checkbox inputs for document builder flow
slavas490 Sep 10, 2023
d6cd0ee
fix unnecessary requests for user data on frontend
slavas490 Sep 10, 2023
b81a509
Merge pull request #1 from slavas490/fix/document-builder-selector-do…
slavas490 Sep 11, 2023
824930e
Merge pull request #2 from slavas490/fix/remove-unnecessary-requests
slavas490 Sep 11, 2023
3fdf1e0
fix login with metamask
slavas490 Sep 11, 2023
a6ed3c3
add validation for the user session cookie
slavas490 Sep 11, 2023
c332178
fix wrong formatting
slavas490 Sep 11, 2023
38ac5f3
add ui support for node:latest (v20)
slavas490 Sep 21, 2023
2ac4a56
Merge pull request #3 from ProxeusApp/preprod
slavas490 Sep 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@ dependencies=go curl
mocks=main/handlers/blockchain/mock/adapter_mock.go storage/mock/interfaces.go
bindata=main/handlers/assets/bindata.go test/assets/bindata.go
golocalimport=github.com/ProxeusApp/proxeus-core
uiextraflags=NODE_OPTIONS=--openssl-legacy-provider
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to me that it needs to be a MacOS, Node 17 only fix.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

circleci still running it with 16 node.js

maybe we should update our circleci config to be able to use this flag

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's upgrade CircleCI to 20.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed today, we are probably not quite ready for Node 20.x. I've updated this in #397


.PHONY: all
all: ui server
Expand All @@ -93,11 +94,11 @@ update:

.PHONY: ui
ui:
$(MAKE) -C ui
$(uiextraflags) $(MAKE) -C ui

.PHONY: ui-dev
ui-dev:
$(MAKE) -C ui serve-main-hosted
$(uiextraflags) $(MAKE) -C ui serve-main-hosted

.PHONY: generate
generate: $(bindata) $(mocks)
Expand Down