Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

USB comm: prepare for @micolous change (PR#463) #587

Merged
merged 1 commit into from
Mar 31, 2018
Merged

USB comm: prepare for @micolous change (PR#463) #587

merged 1 commit into from
Mar 31, 2018

Conversation

pwpiwi
Copy link
Contributor

@pwpiwi pwpiwi commented Mar 28, 2018 •
edited
Loading

  • move communication related code from proxmark3.c and cmdmain.c to new file comms.c
  • replace byte_t by uint8_t in uart_posix.c and uart_win32.c
  • move OpenProxmark() and CloseProxmark() from flasher.c to flash.c
  • move print_lock mutex including initializer to ui.c
  • minor changes in printing help texts
  • no changes in comms functionality yet, just a preparation for PR Comms refactor mk2 #463

@pwpiwi
USB comm: prepare for @micolous change (PR#463)
fc583fb 
* move communication related code from proxmark3.c and cmdmain.c to new file comms.c
* replace byte_t by uint8_t in uart_posix.c and uart_win32.c
* move OpenProxmark() and CloseProxmark() from flasher.c to flash.c
* move print_lock mutex including initializer to ui.c
* minor changes in printing help texts
* no changes in comms functionality yet
@pwpiwi pwpiwi mentioned this pull request Mar 28, 2018
Closed
@micolous
Copy link
Contributor

Works fine on Ubuntu 17.10 (readline + gui) and OSX 10.13.3 (libedit + no gui)

Test procedure:

  1. Build
  2. Run flasher with no arguments, ModemManager note is only shown on Linux, port is correct for platform
  3. Reflash device with flasher and firmware
  4. Run PM3
  5. hw tune with LF antenna
  6. lf search some LF cards
  7. hw tune with HF antenna
  8. hf search and hf 14a info some HF/ISO14a cards
  9. hf mf nested 1 * t a MFC card

@pwpiwi pwpiwi merged commit f5ecd97 into Proxmark:master Mar 31, 2018
@pwpiwi pwpiwi deleted the micolous_prep branch March 31, 2018 07:52
@micolous micolous mentioned this pull request Jul 26, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@micolous micolous micolous approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pwpiwi @micolous