Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building in Windows (Instead of Mono) causes traps to just not work #43

Closed
tysonstrange opened this issue Oct 22, 2015 · 24 comments
Closed

Comments

@tysonstrange
Copy link
Contributor

When you use VS To build in windows, it will build but no traps will trigger.

Seems teleporters and shit still work though, so its not all mechanics.

@hakusaro
Copy link
Member

That's very, very weird.

@QuiCM
Copy link
Member

QuiCM commented Oct 22, 2015

This issue has been around for a while. We never figured out the cause. Fortunately Travis builds with Mono

@tysonstrange
Copy link
Contributor Author

Tell me about it....

Ask Tyler and see what he thinks about it... hahahahahahaha

@hakusaro
Copy link
Member

@WhiTexz *bamboo

@QuiCM
Copy link
Member

QuiCM commented Oct 22, 2015

Yeah, that

@tysonstrange
Copy link
Contributor Author

Well, orion will probably take care of that, along with countless other issues.

not a big deal.

@gerardmistletoe
Copy link

It's not Windows specific. I build and run with Mono (xbuild) on Linux and traps don't work.

@Arrenton
Copy link

Same here. I tried to build in Mono using Linux and xbuild and it still doesn't work. I have tried Xamarin Studio as well in Windows to try and build Mono, with the same results.
Hopefully this does get fixed.

@hakusaro
Copy link
Member

What version of Mono?
On Mon, Nov 23, 2015 at 12:26 AM Gotest notifications@github.com wrote:

Same here. I tried to build in Mono using Linux and xbuild and it still
doesn't work. I have tried Xamarin Studio as well in Windows to try and
build Mono, with the same results.
Hopefully this does get fixed.


Reply to this email directly or view it on GitHub
#43 (comment)
.

@Arrenton
Copy link

I would assume the latest since I used the install guide for linux on mono-project.com. (http://www.mono-project.com/docs/getting-started/install/linux/) But if you need me to check, I can.

EDIT: Linux is using Mono JIT Compiler version 4.2.1.102

@QuiCM
Copy link
Member

QuiCM commented Nov 23, 2015

Using Ubuntu 14.04 and Mono 4.0.5, traps work when the project is compiled with xbuild

@tylerjwatson
Copy link
Member

Linux is using Mono JIT Compiler version 4.2.1.102

Thanks. This is important because it gives us something to look at, particularly the diffs between 4.2.1 and 4.0.5. Now that the .NET CLR and the BCL is open source, mono have continuously been adopting MS implementations in lieu of their own in the interest of binary compatibility. It could be something in these references that are causing this.

I still don't have anything concrete to go on, but its a start.

@Arrenton
Copy link

Compiling with Mono 4.0.5 worked! Thank you guys so much!

Here's to me hoping you guys can figure out what's going on here! Best of luck to you!

@tylerjwatson
Copy link
Member

According to http://www.mono-project.com/docs/about-mono/releases/4.2.1/, it replaces some ~500 types with Microsoft's implementation.

This is going to be a pain.

@Arrenton
Copy link

I would like to note this also fixes Training Dummies, and invisible Bombs/Dynamite.
Although Campfires still seem to disappear when trying to disable them (right click.)

@tysonstrange
Copy link
Contributor Author

Holy. Fucking. Shit.

Invis bombs are fixed? Gimme.

@hakusaro
Copy link
Member

Hmm, the build server is on 4.0.2.0. Invisible bombs happen in the latest
official build?

On Tue, Nov 24, 2015 at 6:03 PM tysonstrange notifications@github.com
wrote:

Holy. Fucking. Shit.

Invis bombs are fixed? Gimme.


Reply to this email directly or view it on GitHub
#43 (comment)
.

@tysonstrange
Copy link
Contributor Author

Hmm, the build server is on 4.0.2.0. Invisible bombs happen in the latest
official build?

Yeah, pretty sure its still an issue here

@Arrenton
Copy link

Okay, so the invisible bombs aren't 100% fixed but they're working almost 80% of the time now instead of never working at all.

@tysonstrange
Copy link
Contributor Author

Okay, so the invisible bombs aren't 100% fixed but they're working almost 80% of the time now instead of never working at all

Thats how it's always been...

It's never been so bad that they're invisible 100% of the time.

@tylerjwatson
Copy link
Member

On my mono-4.2.1 instance, I am able to trigger a super dart trap with a lever once, and only once if the solution is compiled in release mode with xbuild /p:Configuration=Release.

@QuiCM
Copy link
Member

QuiCM commented Nov 25, 2015

I was able to trigger dart traps, spear traps, and flame traps continuously using a switch with a 4.2.1 instance

@tylerjwatson
Copy link
Member

More info? I should be able to trigger a super dart trap from a wire and a lever, right? Doesn't have to be in a certain biome or at night? Any other variables? Platform? Did you compile it or run stock?

Mono-4.0 binaries from our CI has always worked. This doesn't work when I compile the image using >= mono-4.0.2 or windows

tylerjwatson added a commit to Pryaxis/TShock that referenced this issue Nov 25, 2015
@hakusaro
Copy link
Member

👍👍👍😘😘😘
On Wed, Nov 25, 2015 at 7:33 AM Tyler Watson notifications@github.com
wrote:

Closed #43 #43
via 89f0d08
89f0d08
.


Reply to this email directly or view it on GitHub
#43 (comment)
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants