Arm64 implementation for Raspberry PI #2606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should allow monomod hooks to run on a raspberrypi (no apple silicon yet)
There is a slight change the the way QueryResult works in order to satisfy the variances in the new library. Disposing of the command with the reader appears to solve this, and hopefully, with minimal impact to plugins.
hakusaro
approved these changes
Mar 27, 2022
Co-authored-by: Lucas Nicodemus <shank@shanked.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR bumps all dependencies to their latest, and in particular MonoMod for its new Arm64 support for raspberry pi thanks to @kevzhao2.
I have also changed the SQLite library to use Microsoft.Data.Sqlite as it works out of the box for Arm64, so there is a slight change for the QueryResult to dispose of the command instead of disposing of it preemptively.
Note: apple silicon is not included in this, yet.
Note 2: i didn't bother adding arm64 support to the changelog, since it already has the expectation of working for the current gen-dev, but i'm happy to do so as kev's work does need some praise.