Initial FemWorkbench refraction towards CaeWorkbench see /Fem/Readme.md for details #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…md for details, C++ untouched
|
Could you provide some high-level overview of what's happening in the commit description? Would it be possible to split the commit into smaller chunks? It's easy to omit something when reviewing commit that it changing 25 files and it's very hard to bisect with big commits. I.e I'd suggest to file handle renames in separate commits. Thank you for your work! P.S. You should probably send pull request to the master repository |
|
I see quite a lot trailing spaces and empty lines with white spaces - please remove. |
|
I will clean up my code and send another pull request, Thanks |
PrzemoF
pushed a commit
that referenced
this pull request
Oct 13, 2018
PrzemoF
pushed a commit
that referenced
this pull request
Oct 13, 2018
Typo fix for Archstair_Improvement9
PrzemoF
pushed a commit
that referenced
this pull request
May 5, 2020
Path: Fix `ZigZag` pattern; Remove some comments
PrzemoF
pushed a commit
that referenced
this pull request
May 22, 2020
Path: Extend fix to `updateVisibility()`
PrzemoF
pushed a commit
that referenced
this pull request
Mar 19, 2021
Fixes Coverity issue: CID 316539 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR) uninit_member: Non-static class member lastHasPartialRedundancies is not initialized in this constructor nor in any functions that it calls.
PrzemoF
pushed a commit
that referenced
this pull request
Mar 19, 2021
Coverity warnings fixed: CID 316517 (#1 of 1): Uninitialized scalar variable (UNINIT) 13. uninit_use_in_call: Using uninitialized value t. Field t.err is uninitialized when calling push_back CID 316519 (#1 of 1): Uninitialized scalar variable (UNINIT) 3. uninit_use_in_call: Using uninitialized value v. Field v.tstart is uninitialized when calling push_back CID 316547 (#1 of 1): Uninitialized scalar variable (UNINIT) 13. uninit_use_in_call: Using uninitialized value t. Field t.err is uninitialized when calling push_back CID 316556 (#1 of 1): Uninitialized scalar variable (UNINIT) 3. uninit_use_in_call: Using uninitialized value v. Field v.tstart is uninitialized when calling push_back
PrzemoF
pushed a commit
that referenced
this pull request
Mar 19, 2021
Coverity warnings fixed: CID 316550 (#1 of 1): Uninitialized scalar variable (UNINIT) 13. uninit_use_in_call: Using uninitialized value sel. Field sel.pResolvedObject is uninitialized when calling push_back
PrzemoF
pushed a commit
that referenced
this pull request
Mar 19, 2021
Coverity warnings fixed: CID 316559 (#1 of 1): Uninitialized scalar variable (UNINIT) 3. uninit_use_in_call: Using uninitialized value we. Field we.idx is uninitialized when calling push_back CID 316549 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR) 4. uninit_member: Non-static class member pageheight is not initialized in this constructor nor in any functions that it calls. CID 186161 (#1 of 1): Uninitialized pointer field (UNINIT_CTOR) 2. uninit_member: Non-static class member parent is not initialized in this constructor nor in any functions that it calls. CID 305170 (#1 of 1): Dereference before null check (REVERSE_INULL) check_after_deref: Null-checking this->m_baseFeat suggests that it may be null, but it has already been dereferenced on all paths leading to the check. CID 186152 (#2 of 2): Uninitialized pointer field (UNINIT_CTOR) 3. uninit_member: Non-static class member m_mdi is not initialized in this constructor nor in any functions that it calls. CID 192588 (#1 of 1): Same on both sides (CONSTANT_EXPRESSION_RESULT) pointless_expression
PrzemoF
pushed a commit
that referenced
this pull request
Mar 19, 2021
Coverity warnings fixed: CID 305123 (#1 of 1): Logically dead code (DEADCODE) dead_error_line: Execution cannot reach the expression this->linked inside this statement: if (role == Qt::TextColorRole && linked)
PrzemoF
pushed a commit
that referenced
this pull request
Mar 19, 2021
Coverity warnings fixed: CID 129530 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR) 2. uninit_member: Non-static class member pixelScalingFactor is not initialized in this constructor nor in any functions that it calls.
PrzemoF
pushed a commit
that referenced
this pull request
Aug 24, 2021
Prevent matplotlib selecting the PyQt API instead of PySide2
PrzemoF
pushed a commit
that referenced
this pull request
Feb 19, 2022
…essor Path: KineticNC Postprocessor
PrzemoF
pushed a commit
that referenced
this pull request
Jul 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I can run the Gui using my new code, but write_case_file() which writes inp file does not return. I find the same problem using latest FreeCAD git-dev deb installation. Perhaps you can shed me light on this.
I worked on official FreeCAD master code on Sep 23, 2015, while FEM got 2 new python files added about Sep 27. I tried to add these into my Fem folders. As Fem module is developing heavily, I hope code shared by Fem and Cfd could be merged, before I focus on CFD implementation. Thanks.