Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AudioUtil: In Explorers of Sky, Track #1, is missing Instrument #14 #42

Open
tommai78101 opened this issue Dec 22, 2017 · 4 comments
Open
Assignees
Labels

Comments

@tommai78101
Copy link

tommai78101 commented Dec 22, 2017

I was able to get Instruments #1 through #13, but the Instrument #14 is missing from the exported output. I even re-verified if the template XML is corrupted and re-created the XML template. And then I noticed the first track (bgm001) is missing what I'm assuming to be the Brass instrument. The note for Instrument #14 matched with a certain sample that's not in the XML template.

In Track #1, 1_B_SYS_P3_OPENIN.mid, on Note Patterns 6, 7, and 8, Instrument #14 uses a total of 12 notes, and for that, I can't tell what that note sounds like, when played from an emulator. It's definitely not Drums, otherwise there would be more than 12 notes.

@PsyCommando
Copy link
Owner

Can you clarify what kind of export you did? Just midis, or midi+soundfonts?
Because the template XML is used only for straight midi export.

@PsyCommando PsyCommando added the bug label Jan 2, 2018
@tommai78101
Copy link
Author

tommai78101 commented Jan 2, 2018

Happy New Year!

I used the midi + soundfonts.

I didn't realize the template XML is used only for straight MIDI export.

@PsyCommando
Copy link
Owner

Happy new year!
And thanks for clearing that up! I'll have to look into that. I'm thinking of rewriting the thing from scratch at this point, though. Its been a recurring issue, and I don't know if just patching it is gonna be good enough...

Template xml is just for mapping general midi instruments and drums to the instruments used in the game basically. Its meant to be flexible so people can make an xml file for any game they want and use it in the conversion.

@PsyCommando PsyCommando self-assigned this Jan 2, 2018
@tommai78101
Copy link
Author

Thanks for looking into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants