Development enable lint #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # internal/delivery/http/route_users_test.go
# Conflicts: # internal/delivery/http/route_users_mock_test.go
merge development to development_enable_lint
增加 githubci lint
修正 enable_lint branch 的 Google Action steps
…le_test Test/#74add route boards article test
…/Ptt-backend into feature/fix_errcheck
fix goimports
修正了除了 interface 跟 mock 以外的 id
# Conflicts: # .github/workflows/go.yaml # internal/usecase/board.go
2021/02/22 ~2021/03/01 development to development_enable_lint
…test 添加 getUserFavorites 測試
# Conflicts: # internal/delivery/http/route.go # internal/delivery/http/route_boards_mock_test.go # internal/delivery/http/route_classes_mock_test.go
同步 development 跟 development_enable_lint
…easures_test 實作 #route board treasures test
# Conflicts: # internal/delivery/http/route_users.go # internal/delivery/http/route_users_test.go
Development enable lint
Codecov Report
@@ Coverage Diff @@
## development #140 +/- ##
==============================================
Coverage ? 36.06%
==============================================
Files ? 21
Lines ? 804
Branches ? 0
==============================================
Hits ? 290
Misses ? 467
Partials ? 47 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👏 解決掉的 issue / Resolved Issues
⛏ 變更內容 / Details of Changes
二合一