Atc 534 server side tracking support #727
Conversation
| }; | ||
|
|
||
| export const generatePayload = (auctionData, lsObj) => { | ||
| const adSizeKeys = Object.keys(lsObj).filter(key => /([0-9]+x[0-9]+)/.test(key)); |
There was a problem hiding this comment.
I could not get what exactly we are doing here.
There was a problem hiding this comment.
right here we are just gathering all of the ad size keys currently in local storage using regex and storing them in an array (ex. key names like "300x250", "728x90", etc.)
|
|
||
| export const generatePayload = (auctionData, lsObj) => { | ||
| const adSizeKeys = Object.keys(lsObj).filter(key => /([0-9]+x[0-9]+)/.test(key)); | ||
| const adUnitKeys = Object.keys(lsObj).filter(key => !/([0-9]+x[0-9]+)/.test(key) && key !== window.location.hostname); |
There was a problem hiding this comment.
I could not get what exactly we are doing here.
There was a problem hiding this comment.
similar to above, here we are just gathering all ad slot name entries in local storage, but using regex to filter out ad size entries and ad domain entries. then storing all ad slot name entries in an array.
| }; | ||
| }; | ||
|
|
||
| const getPubId = auctionData => { |
There was a problem hiding this comment.
Do we need this function? Or can we read this from PWT ?
There was a problem hiding this comment.
Ah good question, I doubled checked if we could take this from PWT, but looks like I wasn't able to find the publisher id on there. So I guess this function would be ok to keep.
Type of change
Description of change
Other information
https://inside.pubmatic.com:9443/jira/browse/ATC-534
https://inside.pubmatic.com:9443/jira/browse/UOE-9086