-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Atc 534 server side tracking support #727
base: UOE-9337
Are you sure you want to change the base?
Conversation
}; | ||
|
||
export const generatePayload = (auctionData, lsObj) => { | ||
const adSizeKeys = Object.keys(lsObj).filter(key => /([0-9]+x[0-9]+)/.test(key)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could not get what exactly we are doing here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
right here we are just gathering all of the ad size keys currently in local storage using regex and storing them in an array (ex. key names like "300x250", "728x90", etc.)
|
||
export const generatePayload = (auctionData, lsObj) => { | ||
const adSizeKeys = Object.keys(lsObj).filter(key => /([0-9]+x[0-9]+)/.test(key)); | ||
const adUnitKeys = Object.keys(lsObj).filter(key => !/([0-9]+x[0-9]+)/.test(key) && key !== window.location.hostname); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could not get what exactly we are doing here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
similar to above, here we are just gathering all ad slot name entries in local storage, but using regex to filter out ad size entries and ad domain entries. then storing all ad slot name entries in an array.
}; | ||
}; | ||
|
||
const getPubId = auctionData => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this function? Or can we read this from PWT ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah good question, I doubled checked if we could take this from PWT, but looks like I wasn't able to find the publisher id on there. So I guess this function would be ok to keep.
Type of change
Description of change
Other information
https://inside.pubmatic.com:9443/jira/browse/ATC-534
https://inside.pubmatic.com:9443/jira/browse/UOE-9086