-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable-8 create a better character counter widget #144
Enable-8 create a better character counter widget #144
Conversation
…iate <p> element instead of <div> for announcements.
…efactor counter container element and allow for a template like before.
…ta-has-character-count. Respect internationalization of strings.
This page currently has the following text for the character count section:
Are we still using a JavaScript library? If so, I think we should mention which library it is. If not, then this text needs to be changed. |
…acter-count is true.
…t attribute instead of hasCharacterCount.
…plicitly set to 'true'.
…idget Signed-off-by: Jadan Ou <17204721+ocjadan@users.noreply.github.com>
Hi @zoltan-dulac , I've decided on going with adding/removing an exclamation to the end of the text to force Chrome to "see a difference" on each key press. For example:
This approach works for Safari, Firefox and Chrome with VoiceOver on Mac. |
If you were wondering, here are other methods I've tried: Did not work ❌:
aria-atomic
aria-relevant
aria-live
aria-busy
Other Methods
|
…ifier/navigation.
…n readers to work.
…r-character-counter ENABLE-145 Unit Tests for Character Counter
…idget Signed-off-by: Jadan Ou <17204721+ocjadan@users.noreply.github.com>
width: 15rem; | ||
float: left; | ||
} | ||
.enable-character-count { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we have a default style for the enable-character-counter and have it is part of the NPM package?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @zoltan-dulac ,
Trying to understand your request a bit more, the <div< element that this style is applied to is programmatically added below the <textarea> — the <div> does not exist before the JavaScript is ran. As a result, I was wondering if you meant:
- Programmatically and explicitly setting the style, e.g.
div.setAttribute("style", "border-color:#FFFFFF;");
? - enable-character-count.js should import less/textbox.less and apply the style programmatically?
No description provided.