Masked input test #56
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoltan-dulac
reviewed
Mar 8, 2024
| ); | ||
| expect(maskedTelephone).toBe("123-456-781"); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
These are great so far! Thank you.
I would also like to ensure we test the mouse functionality as well:
- Can we have a test that will click in the middle of a filled out masked input field? I want the test to be able to detect if the visual cursor and the input cursor match up.
- Another similar test to see if, when selecting a string in the middle of the input field, the visual selected and the input selected area match up.
- Checking what happens if invalid input occurs. e.g. letters in phone numbers.
There was a problem hiding this comment.
Copy, will work on getting these in.
Minor HTML and code comment improvements
Fix spelling and gremlin characters (issue #49)
Improve scripts to use localhost if IP is blocked by firewall
Switch the colours for npm notifications and do not use (issue #39)
Add a hover style to drawer button controls (issue #46)
…on, Added package RobotJS
Update the sitemap with pages previously wip
Updates to code quality page
Chore/update readme
Fixed PHP binPath for windows users
…b.com/PublicisSapient/enable-a11y into 89-vd-change-form-error-checking-page
feat: Adding icons next to headings to have summarized info
…into 89-vd-change-form-error-checking-page
…checking-page removing : and space between asterik
…e-a11y into masked-input-test
…checking-page commiting css change in .less file also
…ibs are installed.
…e-a11y into masked-input-test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the following: