Rename 'artifact' to '_artifact' #1164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This name of field is changing inside core and in plugins to show it is 'core' field of pulp. https://pulp.plan.io/issues/4282 Signed-off-by: Pavel Picka <ppicka@redhat.com>
pavelpicka
added a commit
to pavelpicka/pulp
that referenced
this pull request
Jan 28, 2019
Renaming to '_artifact' to be clearer that artifact is part of pulpcore. as continue for #4206 refactor. Fix for testing. re: #4282 https://pulp.plan.io/issues/4282 Required PR: pulp/pulp_file#158 Required PR: pulp/pulp-smash#1164 Signed-off-by: Pavel Picka <ppicka@redhat.com>
nixocio
changed the title
pavelpicka
added a commit
to pavelpicka/pulp
that referenced
this pull request
Jan 28, 2019
Renaming to '_artifact' to be clearer that artifact is part of pulpcore. as continue for #4206 refactor. Fix for testing. re: #4282 https://pulp.plan.io/issues/4282 Required PR: pulp/pulp_file#158 Required PR: pulp/pulp-smash#1164 Signed-off-by: Pavel Picka <ppicka@redhat.com>
pavelpicka
added a commit
to pavelpicka/pulp
that referenced
this pull request
Jan 28, 2019
Renaming to '_artifact' to be clearer that artifact is part of pulpcore. as continue for #4206 refactor. Fix for testing. re: #4282 https://pulp.plan.io/issues/4282 Required PR: pulp/pulp_file#158 Required PR: pulp/pulp-smash#1164 Signed-off-by: Pavel Picka <ppicka@redhat.com>
dralley
added a commit
to dralley/pulpcore-plugin
that referenced
this pull request
Jan 31, 2019
Remove boilerplate from the plugins by defining new, more specialized serializers for the single-artifact-per-content case, the multiple-artifacts-per-content case, and the no-artifacts-per-content case. Required PR: pulp/pulp_file#159 Required PR: pulp/pulp#3846 Required PR: pulp/pulp-smash#1164 re: #4340 https://pulp.plan.io/issues/4340 re: #4366 https://pulp.plan.io/issues/4366
dralley
added a commit
to dralley/pulp
that referenced
this pull request
Jan 31, 2019
Remove boilerplate from the plugins by defining new, more specialized serializers for the single-artifact-per-content case, the multiple-artifacts-per-content case, and the no-artifacts-per-content case. Required PR: pulp/pulp_file#159 Required PR: pulp/pulp-smash#1164 Required PR: pulp/pulpcore-plugin#38 re: #4340 https://pulp.plan.io/issues/4340 re: #4366 https://pulp.plan.io/issues/4366
dralley
added a commit
to dralley/pulp_file
that referenced
this pull request
Jan 31, 2019
Required PR: pulp/pulp#3846 Required PR: pulp/pulp-smash#1164 Required PR: pulp/pulpcore-plugin#38 closes: #4340 https://pulp.plan.io/issues/4340 re: #4366 https://pulp.plan.io/issues/4366
dralley
added a commit
to dralley/pulpcore-plugin
that referenced
this pull request
Jan 31, 2019
Remove boilerplate from the plugins by defining new, more specialized serializers for the single-artifact-per-content case, the multiple-artifacts-per-content case, and the no-artifacts-per-content case. Required PR: pulp/pulp_file#159 Required PR: pulp/pulp#3846 Required PR: pulp/pulp-smash#1164 re: #4366 https://pulp.plan.io/issues/4366
dralley
added a commit
to dralley/pulp
that referenced
this pull request
Jan 31, 2019
Remove boilerplate from the plugins by defining new, more specialized serializers for the single-artifact-per-content case, the multiple-artifacts-per-content case, and the no-artifacts-per-content case. Required PR: pulp/pulp_file#159 Required PR: pulp/pulp-smash#1164 Required PR: pulp/pulpcore-plugin#38 re: #4366 https://pulp.plan.io/issues/4366
dralley
added a commit
to dralley/pulp
that referenced
this pull request
Jan 31, 2019
Remove boilerplate from the plugins by defining new, more specialized serializers for the single-artifact-per-content case, the multiple-artifacts-per-content case, and the no-artifacts-per-content case. Required PR: pulp/pulp_file#159 Required PR: pulp/pulp-smash#1164 Required PR: pulp/pulpcore-plugin#38 re: #4366 https://pulp.plan.io/issues/4366
dralley
added a commit
to dralley/pulp
that referenced
this pull request
Jan 31, 2019
Remove boilerplate from the plugins by defining new, more specialized serializers for the single-artifact-per-content case, the multiple-artifacts-per-content case, and the no-artifacts-per-content case. Required PR: pulp/pulp_file#159 Required PR: pulp/pulp-smash#1164 Required PR: pulp/pulpcore-plugin#38 re: #4366 https://pulp.plan.io/issues/4366
dralley
added a commit
to dralley/pulp_file
that referenced
this pull request
Jan 31, 2019
Required PR: pulp/pulp#3846 Required PR: pulp/pulp-smash#1164 Required PR: pulp/pulpcore-plugin#38 closes: #4340 https://pulp.plan.io/issues/4340 re: #4366 https://pulp.plan.io/issues/4366
daviddavis
pushed a commit
to pulp/pulp_file
that referenced
this pull request
Jan 31, 2019
Required PR: pulp/pulp#3846 Required PR: pulp/pulp-smash#1164 Required PR: pulp/pulpcore-plugin#38 closes: #4340 https://pulp.plan.io/issues/4340 re: #4366 https://pulp.plan.io/issues/4366
nixocio
changed the title
nixocio
approved these changes
Jan 31, 2019
daviddavis
pushed a commit
to daviddavis/pulp_file
that referenced
this pull request
May 14, 2019
Required PR: pulp/pulp#3846 Required PR: pulp/pulp-smash#1164 Required PR: pulp/pulpcore-plugin#38 closes: #4340 https://pulp.plan.io/issues/4340 re: #4366 https://pulp.plan.io/issues/4366
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This name of field is changing inside core and in
plugins to show it is 'core' field of pulp.
https://pulp.plan.io/issues/4282
Signed-off-by: Pavel Picka ppicka@redhat.com