Fix for holding buttons on remotes of Philips TVs

[mrgreywater]

This fix generates a user-control-released event in case there are two consecutive user-control-pressed events of the same key without the release in between.

This would fix #124 #95 #66

Since I don't own other TVs, it may be good to cross check functionality with TVs from other vendors before merging.

edit: You can find further explanation and logs of the current problematic behaviour here: #95 (comment)

[MilhouseVH]

I'll include this in my RPi OpenELEC test build tonight, which might help get some feedback (mainly if it causes problems).

[mrgreywater]

@MilhouseVH Great, thx!

[mrgreywater]

I found at least one problem which I'm going to address tomorrow.

[MilhouseVH]

No problem, if you update/squash this PR it will be included in the next build (9pm UK time).

So far there's been no howls of complaint, which is usually a good sign...

[mrgreywater]

Squashed some changes, this should make sure some other Philips firmware quirk is not triggered.

[opdenkamp]

I'll give this a go, thanks. But before we can accept this code, we have to ask you to read and sign http://www.pulse-eight.net/contributors

[mrgreywater]

I've sent the contributor agreement 9 days ago, any update on the matter?

[opdenkamp]

haven't had time yet to look into it, sorry

[MilhouseVH]

FYI this has been in my builds for a few months now with no negative (or positive) comments, presumably it's working as expected.

[nelske]

@opdenkamp Sorry for rattling this old item up. I own a Philips TV and tested @MilhouseVH 's build yesterday. Press and hold does not work and also all single button presses result in double the action on KODI side.

Edit: Oh I read the comment in the code, forget the part on the press and hold. I think I have not tested that well enough.

[mrgreywater]

Can you post your debug log? Once with a single press and once while holding a button, similar to this comment: #95 (comment) . Also I would be interested to know which tv model you're using.

[nelske]

@mrgreywater @MilhouseVH @opdenkamp, forget this. It was my Logitech Harmony which acted funny between kodi 15.2 and 16, 17 (Milhouse's builds). Fixed it by troubleshooting the remote once I found out the regular remote was working normally.

@mrgreywater; if it is still of interest, I have the following tv:
http://tweakers.net/pricewatch/456823/philips-32pfk6500-zilver/specificaties/

I'm willing to test stuff if needed :).