Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for holding buttons on remotes of Philips TVs #125

Merged
merged 1 commit into from Nov 25, 2015

Conversation

Projects
None yet
4 participants
@mrgreywater
Copy link
Contributor

mrgreywater commented Aug 8, 2015

This fix generates a user-control-released event in case there are two consecutive user-control-pressed events of the same key without the release in between.

This would fix #124 #95 #66

Since I don't own other TVs, it may be good to cross check functionality with TVs from other vendors before merging.

edit: You can find further explanation and logs of the current problematic behaviour here: #95 (comment)

@MilhouseVH

This comment has been minimized.

Copy link

MilhouseVH commented Aug 8, 2015

I'll include this in my RPi OpenELEC test build tonight, which might help get some feedback (mainly if it causes problems).

@mrgreywater

This comment has been minimized.

Copy link
Contributor Author

mrgreywater commented Aug 8, 2015

@MilhouseVH Great, thx!

@mrgreywater

This comment has been minimized.

Copy link
Contributor Author

mrgreywater commented Aug 9, 2015

I found at least one problem which I'm going to address tomorrow.

@MilhouseVH

This comment has been minimized.

Copy link

MilhouseVH commented Aug 9, 2015

No problem, if you update/squash this PR it will be included in the next build (9pm UK time).

So far there's been no howls of complaint, which is usually a good sign...

Fix for holding buttons on remotes of Philips TVs
This fix generates a user-control-released event in case there are two consecutive user-control-pressed events of the same key without the release in between.

@mrgreywater mrgreywater force-pushed the mrgreywater:philips-button-release-fix branch from cae412e to a197fb3 Aug 10, 2015

@mrgreywater

This comment has been minimized.

Copy link
Contributor Author

mrgreywater commented Aug 10, 2015

Squashed some changes, this should make sure some other Philips firmware quirk is not triggered.

@opdenkamp

This comment has been minimized.

Copy link
Contributor

opdenkamp commented Aug 20, 2015

I'll give this a go, thanks. But before we can accept this code, we have to ask you to read and sign http://www.pulse-eight.net/contributors

@mrgreywater

This comment has been minimized.

Copy link
Contributor Author

mrgreywater commented Aug 29, 2015

I've sent the contributor agreement 9 days ago, any update on the matter?

@opdenkamp

This comment has been minimized.

Copy link
Contributor

opdenkamp commented Sep 1, 2015

haven't had time yet to look into it, sorry

@MilhouseVH

This comment has been minimized.

Copy link

MilhouseVH commented Nov 6, 2015

FYI this has been in my builds for a few months now with no negative (or positive) comments, presumably it's working as expected.

opdenkamp pushed a commit that referenced this pull request Nov 25, 2015

Lars Op den Kamp
Merge pull request #125 from mrgreywater/philips-button-release-fix
Fix for holding buttons on remotes of Philips TVs

@opdenkamp opdenkamp merged commit 09e55bb into Pulse-Eight:master Nov 25, 2015

@nelske

This comment has been minimized.

Copy link

nelske commented Feb 22, 2016

@opdenkamp Sorry for rattling this old item up. I own a Philips TV and tested @MilhouseVH 's build yesterday. Press and hold does not work and also all single button presses result in double the action on KODI side.

Edit: Oh I read the comment in the code, forget the part on the press and hold. I think I have not tested that well enough.

@mrgreywater

This comment has been minimized.

Copy link
Contributor Author

mrgreywater commented Feb 22, 2016

Can you post your debug log? Once with a single press and once while holding a button, similar to this comment: #95 (comment) . Also I would be interested to know which tv model you're using.

@nelske

This comment has been minimized.

Copy link

nelske commented Feb 22, 2016

@mrgreywater @MilhouseVH @opdenkamp, forget this. It was my Logitech Harmony which acted funny between kodi 15.2 and 16, 17 (Milhouse's builds). Fixed it by troubleshooting the remote once I found out the regular remote was working normally.

@mrgreywater; if it is still of interest, I have the following tv:
http://tweakers.net/pricewatch/456823/philips-32pfk6500-zilver/specificaties/

I'm willing to test stuff if needed :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.