Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for iMX.6 #323

Merged
merged 6 commits into from
Apr 7, 2020
Merged

Conversation

warped-rudi
Copy link
Contributor

Finally... This patch set adds support for the iMX.6 SoC. It is based on the original code by @wolfgar from 2014. Even though it should work with his original kernel driver, it's suggested to use this driver. So far it has only been tested with the 'official' SolidRun 3.14.xx series kernels.

@dougnazar
Copy link

Ironically I spend an hour today updating it too before I thought to check if there was a pull request. I only use the basics (on, off, etc) but it works fine for me on several i.MX6 devices and various TVs.

Thanks,
Doug

@opdenkamp
Copy link
Contributor

I'll have to check this after doing a minor release with fixes. Thanks :)

@Hedda
Copy link
Contributor

Hedda commented Jan 7, 2019

@warped-rudi does this need to be updated to be compatible with iMX.8 (and iMX.7) SoCs?

I saw that SolidRun have a new iMX 8 based CuBox as well as a new HummingBoard board.

@warped-rudi
Copy link
Contributor Author

This stuff is compatible with SolidRun's 3.x and 4.9.x kernels for iMX.6, which in turn are derived from the chip vendor's non-mainline kernels. It appears that SolidRun is working on a unified 4.9 for all their iMX products and I guess/hope that we we can use this code for iMX.8 as well. But it could also be, that iMX.8 will be using the newer kernel CEC framework.

@opdenkamp
Copy link
Contributor

@warped-rudi sorry for the delay. If this PR is still relevant with the current iMX hardware/software, could you then rebase it so I can include it in the upcoming release. Also, if you haven't signed this yet, please take a look at https://www.pulse-eight.com/contributors

If it's all using the Linux in-kernel implementation now, then this is no longer needed. Thanks

@warped-rudi
Copy link
Contributor Author

@opdenkamp I rebased to the patch and did a quick test t verify that it works on an older iMX.6 board. I kinda lost track of the current status of the iMX.6 mainline support, but AFAIK it's still not as good as the old vendor kernels with respect to multimedia. Therefore I'd like to see it included. As for the contributors agreement: I'm pretty sure that I already signed it when I submitted the TDA995x stuff many years ago.

@opdenkamp
Copy link
Contributor

Thanks for the update and for the patch. There are a couple of small cosmetic issues that I'll fix up later.

@opdenkamp opdenkamp merged commit 72ae683 into Pulse-Eight:master Apr 7, 2020
@warped-rudi
Copy link
Contributor Author

Talking about cleanup: It appears that all of the "custom" adapters implement a member function named 'XXXCECAdapterCommunication::HandleLogicalAddressLost()'. I think this is a leftover from earlier days and is not needed anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants