Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/windows build path spaces #475

Merged

Conversation

Vavassor
Copy link
Contributor

@Vavassor Vavassor commented Oct 4, 2019

This is to address #474. Since the affected batch scripts are split over submodules, I also submitted two other pull requests in Pulse-Eight/libcec-support and Pulse-Eight/platform.

@kdschlosser
Copy link
Contributor

@Vavassor

I was wondering if you could do me a favor?. I am sure you have gotten to know your way around the build scripts for libcec. I think that the build scripts limit you to using VS 2012, 2013, 2015 if memory serves. There might be an issue with the C++ runtime libraries that get compiled into the installer.

I have an installer made by @opdenkamp and the dll was compiled using VS 2013 but the included runtimes were 2015. I do not know if the runtimes from the VS VC installation get used or if they are hard coded. Or to even go about fixing it if there is an issue. would you be willing to check into this and see if there is a possible issue with it?

@opdenkamp
Copy link
Contributor

I'm merging this PR in along with some other PRs in a few. I removed the VS version bump from this one. That'll be done separately a bit later
Thanks!

@opdenkamp opdenkamp merged commit 3387ea6 into Pulse-Eight:master Mar 28, 2020
opdenkamp added a commit that referenced this pull request Mar 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants