Add crowdloan rewards to non-transfer proxy #1048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
girazoki
added
the
B7-runtimenoteworthy
crystalin
approved these changes
Dec 2, 2021
JoshOrndorff
suggested changes
Dec 2, 2021
There was a problem hiding this comment.
This PR allows Proxy accounts of type NonTransfer to interact with the crowdloan rewards pallet on behalf of the proxied account. The primary user-facing benefit of this change is that the proxy accounts can claim rewards. However, it also provides access to all other crowdloan rewards extrinsics including associate_native_identity, and change_rewards_address.
I believe providing access to change_reward_address is a security hole. With this change, a proxy account could redirect unclaimed rewards to their own account, thereby stealing the rewards from the proxied account.
JoshOrndorff
approved these changes
Dec 2, 2021
librelois
approved these changes
Dec 2, 2021
|
I can do that, does not cost me anything now that I have the basic test in |
nanocryk
approved these changes
Dec 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Adds Crowdloan rewards to non-transfer proxy
What important points reviewers should know?
Is there something left for follow-up PRs?
What alternative implementations were considered?
Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?
What value does it bring to the blockchain users?