Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add multisigs pallet to Moonriver and Moonbeam #2264

Merged
merged 5 commits into from
May 11, 2023
Merged

Add multisigs pallet to Moonriver and Moonbeam #2264

merged 5 commits into from
May 11, 2023

Conversation

Agusrodri
Copy link
Contributor

@Agusrodri Agusrodri commented Apr 25, 2023 •
edited

What does it do?

This PR adds the possibility to use Multi-signature accounts within Moonriver and Moonbeam.

Changes

  • Added pallet-multisig and its corresponding config to Moonriver and Moonbeam runtimes.

What value does it bring to the blockchain users?

Users are now able to easily manage multisig accounts using ETH-type addresses from PolkadotJs UI.

@Agusrodri Agusrodri added B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D5-nicetohaveaudit⚠️ PR contains trivial changes to logic that should be properly reviewed. not-breaking Does not need to be mentioned in breaking changes labels Apr 25, 2023
@Agusrodri Agusrodri added D9-needsaudit👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited and removed D5-nicetohaveaudit⚠️ PR contains trivial changes to logic that should be properly reviewed. labels Apr 27, 2023
crystalin
crystalin reviewed May 9, 2023
View reviewed changes
runtime/moonbeam/src/lib.rs Show resolved Hide resolved
runtime/moonbeam/src/lib.rs Outdated Show resolved Hide resolved
librelois
librelois requested changes May 9, 2023
View reviewed changes
Copy link
Collaborator

@librelois librelois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The DepositFactor should be 20

@Agusrodri Agusrodri requested a review from librelois May 9, 2023 16:22
@Agusrodri Agusrodri requested a review from librelois May 9, 2023 16:36
@Agusrodri Agusrodri merged commit 9c432cf into master May 11, 2023
24 checks passed
@Agusrodri Agusrodri deleted the agustin-multisigs-moonbeam-moonriver branch May 11, 2023 14:23
@notlesh notlesh added D1-audited👍 PR contains changes to fund-managing logic that has been properly reviewed and externally audited and removed D9-needsaudit👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited labels May 17, 2023
@Agusrodri Agusrodri mentioned this pull request Jun 6, 2023
Merged
@Agusrodri Agusrodri added breaking Needs to be mentioned in breaking changes and removed not-breaking Does not need to be mentioned in breaking changes labels Jun 7, 2023
@crystalin crystalin changed the title Add multisigs to Moonriver and Moonbeam Add multisigs pallet to Moonriver and Moonbeam Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crystalin crystalin crystalin left review comments

@tmpolaczyk tmpolaczyk tmpolaczyk left review comments

@librelois librelois librelois approved these changes

Assignees
No one assigned
Labels
B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes breaking Needs to be mentioned in breaking changes D1-audited👍 PR contains changes to fund-managing logic that has been properly reviewed and externally audited
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Agusrodri @crystalin @librelois @tmpolaczyk @notlesh