Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pallet-multisig to Moonbase runtime #2187

Merged
merged 6 commits into from Apr 21, 2023
Merged

Conversation

Agusrodri
Copy link
Contributor

@Agusrodri Agusrodri commented Mar 27, 2023

What does it do?

This PR adds the possibility to use Multi-signature accounts within Moonbase.

Changes

  • Added pallet-multisig and its corresponding config within Moonbase runtime.

What value does it bring to the blockchain users?

Users are now able to easily manage multisig accounts using ETH-type addresses from PolkadotJs UI, a feature that was not available until now.

Note

The parameters for pallet-multisig in Moonbase were also modified in #2264

@Agusrodri Agusrodri added B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D5-nicetohaveaudit⚠️ PR contains trivial changes to logic that should be properly reviewed. not-breaking Does not need to be mentioned in breaking changes labels Mar 27, 2023
@crystalin
Copy link
Collaborator

@Agusrodri For now the pallet should be on Moonbase only.
Also it needs to be announced in the forum before getting merged (for the pallet and also the precompile that will be added (another PR is probably better))

@Agusrodri Agusrodri changed the title Add pallet-multisig to Moonbase, Moonriver and Moonbeam runtimes Add pallet-multisig to Moonbase runtime Mar 28, 2023
@Agusrodri Agusrodri merged commit e8eef18 into master Apr 21, 2023
24 checks passed
@Agusrodri Agusrodri deleted the agustin-pallet-multisig branch April 21, 2023 00:56
@notlesh notlesh added D1-audited👍 PR contains changes to fund-managing logic that has been properly reviewed and externally audited and removed D5-nicetohaveaudit⚠️ PR contains trivial changes to logic that should be properly reviewed. labels May 17, 2023
@Agusrodri Agusrodri added breaking Needs to be mentioned in breaking changes and removed not-breaking Does not need to be mentioned in breaking changes labels Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes breaking Needs to be mentioned in breaking changes D1-audited👍 PR contains changes to fund-managing logic that has been properly reviewed and externally audited
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants