Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix hrmp-manage in XCM Transactor #2306

Merged
merged 4 commits into from
May 16, 2023
Merged

Fix hrmp-manage in XCM Transactor #2306

merged 4 commits into from
May 16, 2023

Conversation

Agusrodri
Copy link
Contributor

@Agusrodri Agusrodri commented May 16, 2023 •
edited

What does it do?

Currently, hrmp-manage() function in XCM Transactor, uses deposit_instruction() function which adds a DepositAsset instruction using Wild(All). This breaks compatibility while converting the message to XCM V2. This PR fixes that issue by using Wild(AllCounted) instead of Wild(All).

Changes

  • Added max_assets parameter to deposit_instruction() function.
  • Changed Wild(All) for Wild(AllCounted(max_assets)) within deposit_instruction() function.

@Agusrodri Agusrodri added B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D5-nicetohaveaudit⚠️ PR contains trivial changes to logic that should be properly reviewed. not-breaking Does not need to be mentioned in breaking changes labels May 16, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 16, 2023 •
edited

Coverage generated "Tue May 16 20:50:16 UTC 2023":
https://s3.amazonaws.com/moonbeam-coverage/pulls/2306/html/index.html

Master coverage: 72.33%
Pull coverage: 72.39%

@Agusrodri Agusrodri merged commit c6b6d3c into master May 16, 2023
@Agusrodri Agusrodri deleted the agustin-fix-hrmp-manage branch May 16, 2023 21:35
@notlesh notlesh added D1-audited👍 PR contains changes to fund-managing logic that has been properly reviewed and externally audited and removed D5-nicetohaveaudit⚠️ PR contains trivial changes to logic that should be properly reviewed. labels Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@girazoki girazoki girazoki approved these changes

@librelois librelois librelois approved these changes

Assignees
No one assigned
Labels
B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D1-audited👍 PR contains changes to fund-managing logic that has been properly reviewed and externally audited not-breaking Does not need to be mentioned in breaking changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Agusrodri @girazoki @librelois @notlesh