Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ERC20-XCM on moonriver and moonbeam #2334

Merged
merged 5 commits into from
Jun 7, 2023
Merged

Conversation

librelois
Copy link
Collaborator

@librelois librelois commented Jun 7, 2023

What does it do?

The XCM configuration for moonriver and moonbeam has not been sufficiently adapted to support erc20 transfers via XCM.

Apply theses changes on moonriver runtime and moonbeam runtime:

  • Add Erc20XcmBridge in the AssetTransactors tuple
  • Add Erc20 variant in CurencyId
  • Refactor AccountIdToCurrencyId converter to resolve to erc20 currency by default
  • Handle Erc20 variant in CurrencyIdtoMultiLocation converter

@librelois librelois added B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D5-nicetohaveaudit⚠️ PR contains trivial changes to logic that should be properly reviewed. not-breaking Does not need to be mentioned in breaking changes labels Jun 7, 2023
@librelois librelois marked this pull request as ready for review June 7, 2023 16:08
@github-actions
Copy link
Contributor

github-actions bot commented Jun 7, 2023

Coverage generated "Wed Jun 7 20:22:21 UTC 2023":
https://s3.amazonaws.com/moonbeam-coverage/pulls/2334/html/index.html

Master coverage: 71.20%
Pull coverage: 71.22%

@librelois librelois merged commit f00e920 into master Jun 7, 2023
26 checks passed
@librelois librelois deleted the elois-fix-currency-id branch June 7, 2023 20:13
@crystalin crystalin changed the title fix erc20-xcm on moonriver and moonbeam Support ERC20-XCM on moonriver and moonbeam Jun 15, 2023
@notlesh notlesh added D1-audited👍 PR contains changes to fund-managing logic that has been properly reviewed and externally audited and removed D5-nicetohaveaudit⚠️ PR contains trivial changes to logic that should be properly reviewed. labels Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D1-audited👍 PR contains changes to fund-managing logic that has been properly reviewed and externally audited not-breaking Does not need to be mentioned in breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants