Fixed Integer overflow crash

PureSwift · Sep 6, 2018 · fec0a38 · fec0a38
1 parent 7876d31
commit fec0a38
Showing 1 changed file with 9 additions and 0 deletions.
diff --git a/Sources/GATTClient.swift b/Sources/GATTClient.swift
@@ -690,6 +690,9 @@ public final class GATTClient {
             guard lastEnd >= operation.start
                 else { operation.completion(.error(Error.invalidResponse(pdu))); return }
 
+            guard lastEnd < .max // End of database
+                else { operation.success(); return }
+
             operation.start = lastEnd + 1
 
             if lastEnd < operation.end {
@@ -743,6 +746,9 @@ public final class GATTClient {
             // get more if possible
             let lastEnd = pdu.handlesInformationList.last?.groupEnd ?? 0x00
 
+            guard lastEnd < .max // End of database
+                else { operation.success(); return }
+
             operation.start = lastEnd + 1
 
             // need to continue scanning
@@ -812,6 +818,9 @@ public final class GATTClient {
             guard lastHandle >= operation.start
                 else { operation.completion(.error(Error.invalidResponse(pdu))); return }
 
+            guard lastHandle < .max // End of database
+                else { operation.success(); return }
+
             let start = lastHandle + 1
 
             // need to continue discovery