Async streaming

[mikalv]

I'm looking at the streaming now. Would it be best with two queues? One for receive and one for sending? or maybe merge them, with a tag in the packet struct with to be sent "in" or "out"?

[orignal]

You don't have other choice but implement outbound queue. Inbound queue is implemented already

[mikalv]

Yes I saw it, and started to add a outbound. But the Stream constructor and some other stuff made me a bit unsure if two queues would be the best option rather than a shared with a tag indicating if the message will be sent out, or is incomming. But thanks for feedback, I'll look on the two queue way 👍

[orignal]

Inbound and outbound queues are independent.
Stream's constructor must be changes for another reason. You don't know LeaseSet for incoming stream before you get connected.

[mikalv]

Aha ok, I will probably need to rewrite/copy/write-a-similar SendPacket as well? More like the ConcatenatePackets, because of the senario where buffer size > max_package_size ?

[orignal]

No. You don't need to concatenate packets.
You split your message for packets based on MTU.

[mikalv]

Ok, so more or less it's just about pushing queued packets into SendPacket, and it will take care of it?

[orignal]

You should read how TCP protocol works, then it will be clear what ti do

[mikalv]

Will do, and try to solve this issue :)

[meeh420]

Issues moved to https://track.privacysolutions.no