Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite #36

Merged
merged 2 commits into from
Feb 8, 2014
Merged

Rewrite #36

merged 2 commits into from
Feb 8, 2014

Conversation

meeh420
Copy link
Contributor

@meeh420 meeh420 commented Feb 8, 2014

No description provided.

@orignal
Copy link
Contributor

orignal commented Feb 8, 2014

if you use int instead for bool considering bool might not be atomic at some platfrom, you shoud also declare this variable as volatile, otherwise you will see some funny behaviour with O3 optimization.
If you set 'running' explicitly, null point should not trigger teminination of a thread anymore. I used this technique temporary just to avoid such not important detail by that time.
Also Queue itself should be rewritten to make it lock-free. using atomic CAS and swap ops.

orignal added a commit that referenced this pull request Feb 8, 2014
@orignal orignal merged commit 74e1840 into PurpleI2P:master Feb 8, 2014
@meeh420
Copy link
Contributor Author

meeh420 commented Feb 8, 2014

Thanks, I will change it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants