Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress deprecation warning due to v1 backwards compatibility #40

Merged
merged 1 commit into from
Aug 15, 2022
Merged

Suppress deprecation warning due to v1 backwards compatibility #40

merged 1 commit into from
Aug 15, 2022

Conversation

lukaskurz
Copy link
Contributor

As mentioned in #39 , the deprecation warning for still using the Registrar can be suppressed, since it's still used for maintaining backwards compatibility.

@nohli
Copy link

nohli commented Dec 21, 2021

@Purus could you merge and publish this, so the two build warnings disappear? 🙏🏽

/Users/achim/flutter/.pub-cache/hosted/pub.dartlang.org/launch_review-3.0.1/android/src/main/java/com/iyaffle/launchreview/LaunchReviewPlugin.java:11: warning: [deprecation] Registrar in PluginRegistry has been deprecated
import io.flutter.plugin.common.PluginRegistry.Registrar;
                                              ^
/Users/achim/flutter/.pub-cache/hosted/pub.dartlang.org/launch_review-3.0.1/android/src/main/java/com/iyaffle/launchreview/LaunchReviewPlugin.java:41: warning: [deprecation] Registrar in PluginRegistry has been deprecated
    public static void registerWith(Registrar registrar) {
                                    ^
2 warnings

@lukaskurz
Copy link
Contributor Author

lukaskurz commented Jan 3, 2022

I'm not sure whether the maintainer of this repo is still active 🤷‍♂️

@Purus Purus merged commit 8dde464 into Purus:master Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants