[BREAKING CHANGES] Many bug fixing and some not retrocompatibility changes

[p4535992]

In this PR I rewrote quite a bit of stuff...test it as much as you can...it seems to me that it all works....

The foundry core not accept anymore flags with a scope not equals to the module id...

  /** @inheritdoc */
  getFlagScopes() {
    if ( this.#flagScopes ) return this.#flagScopes;
    const scopes = ["core", "world", game.system.id]; 
    for ( const module of game.modules ) {
      if ( module.active ) scopes.push(module.id); // why the hell ????
    }
    return this.#flagScopes = scopes;
  }

So anyway now we must migrate all the old scoped flags magicitems to the new scoped flag magic-items-2 as standard (this is why I didn't understand the error at first in all my modules i always used the standard of using module id as the scope of the flags)

I created a dangerous (but tested) function in the module api to be launched manually and after making a safety backup...

game.modules.get("magic-items-2").api.fixFlagsScopeDataOnAllActors()

A brief re-epilogue of this PR

• Exported (and fixed) alla the packs in json formats to better maintenance
• Bug fix: [BUG] Spell doesn't work from magic item: "itemName is not defined"! #79
• Bug fix: [BUG] Magic Item spells not showing on actor sheet #78
• Recovery magic items packs from version 1.6.2 ?
• Rename all references for flags from maicitems to magic-items-2
• Create api function for trasnfer all flags from old to new scope game.modules.get("magic-items-2").api.fixFlagsScopeDataOnAllActors for fix all actor in the world
• Add css color on spells/tables/feats with a broken uuid

[PwQt]

I'll check this during the week, thanks for the help 🤗

[AGCeyx]

@PwQt and @p4535992 thank you for your effort. Is there any way I can help you in testing this? I am using magic items 2 on the forge, how can I apply the patch there? I had been reporting the Bug #78 which is related

[PwQt]

@AGCeyx not really on forge, if you have a local instance you just pull the branch into the /modules/ directory and run

npm install

npm dev to test the functionality

[PwQt]

Seems to be working good, at least the codeside is okay looking for me, i'll test more on Thursday evening and make a release then