Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stub for buffer, descriptor, plane #1306

Merged
merged 8 commits into from
Mar 4, 2024

Conversation

laggykiller
Copy link
Contributor

No description provided.

@WyattBlue
Copy link
Member

def __init__(self, sentinel: object) -> None: ... is wrong. The user can't initialize that object so __init__ shouldn't be in that type stub.

Also, you should always end files with a newline. It's part of our codestyle. GitHub displays a big red sign when a file doesn't.

@WyattBlue WyattBlue closed this Mar 4, 2024
@laggykiller
Copy link
Contributor Author

The user can't initialize that object so init shouldn't be in that type stub.

It is true that the user cannot initialize the object, I agree that I should make change on typing of __init__

However, I think we still need to make stub for those classes, as they could be accessed from other objects such as av.audio.plane.

@laggykiller
Copy link
Contributor Author

What if I change to this: laggykiller@88e9f0f

@WyattBlue WyattBlue reopened this Mar 4, 2024
@WyattBlue WyattBlue merged commit 34359e2 into PyAV-Org:main Mar 4, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants