Fix packet timebase handling during encoding. #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Travis is failing with this error:
I'm a bit puzzled by why nvidia extensions were built at all, could we nuke the cache? |
jlaine
force-pushed
the
encode-with-pts
branch
3 times, most recently
from
fa14a21
to
85b084c
Compare
We must not use the frame's timebase as frame is None while flushing the encoder, which gives random results. In any case we know that frames were rebased into the CodecContext's time_base. For a lengthier discussion see PyAV-Org#397
jlaine
force-pushed
the
encode-with-pts
branch
from
85b084c
to
4855fac
Compare
jlaine
force-pushed
the
encode-with-pts
branch
from
4855fac
to
0d00960
Compare
|
Problem solved by adding libx264 support to all our Travis builds (appveyor already had it). As a nice side effect, we no longer skip |
|
I'm really liking this as our immediate solution. I still want to go on that deep dive to finally decide, once and for all, how time works. But we don't have to do it today. |
|
I agree - let's fix the immediate issue while retaining the overall behaviour and take a breath before we dive deeper. I'm now looking into the subleties of AVCodecContext.time_base vs AVStream.time_base |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We must not use the frame's timebase as frame is None while flushing the
encoder, which gives random results. In any case we know that frames were
rebased into the CodecContext's time_base.
For a lengthier discussion see #397