Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicate dictonary keys #27

Closed
jayvdb opened this issue Oct 25, 2017 · 0 comments · Fixed by #28
Closed

Remove duplicate dictonary keys #27

jayvdb opened this issue Oct 25, 2017 · 0 comments · Fixed by #28
Labels
enhancement gci

Comments

@jayvdb
Copy link
Member

jayvdb commented Oct 25, 2017

https://github.com/PyCQA/pyflakes/releases/tag/1.3.0 included support for detecting duplicate dictionary keys, strictly only reporting when the values differ, as there is no confusion in having the same key,value combination appear multiple times.

It would be nice for autoflake to implement a automatic fixer for this, removing all but the last value for a key in a dictionary.
@myint myint added the gci label Nov 22, 2017
andrewda added a commit to andrewda/autoflake that referenced this issue Jan 2, 2018
@andrewda
Remove duplicate dictionary keys
66d90a8 
This will automatically remove duplicate dictionary keys with the
`--remove-duplicate-keys` argument.

Closes PyCQA#27
andrewda added a commit to andrewda/autoflake that referenced this issue Jan 2, 2018
@andrewda
Remove duplicate dictionary keys
37345c8 
This will automatically remove duplicate dictionary keys with the
`--remove-duplicate-keys` argument.

Closes PyCQA#27
andrewda added a commit to andrewda/autoflake that referenced this issue Jan 2, 2018
@andrewda
Remove duplicate dictionary keys
7d6e69d 
This will automatically remove duplicate dictionary keys with the
`--remove-duplicate-keys` argument.

Closes PyCQA#27
andrewda added a commit to andrewda/autoflake that referenced this issue Jan 2, 2018
@andrewda
Remove duplicate dictionary keys
4f09fec 
This will automatically remove duplicate dictionary keys with the
`--remove-duplicate-keys` argument.

Closes PyCQA#27
andrewda added a commit to andrewda/autoflake that referenced this issue Jan 2, 2018
@andrewda
Remove duplicate dictionary keys
3b97ba6 
This will automatically remove duplicate dictionary keys with the
`--remove-duplicate-keys` argument.

Closes PyCQA#27
@andrewda andrewda mentioned this issue Jan 2, 2018
Merged
andrewda added a commit to andrewda/autoflake that referenced this issue Jan 2, 2018
@andrewda
Remove duplicate dictionary keys
ac70997 
This will automatically remove duplicate dictionary keys with the
`--remove-duplicate-keys` argument.

Closes PyCQA#27
andrewda added a commit to andrewda/autoflake that referenced this issue Jan 3, 2018
@andrewda
Remove duplicate dictionary keys
3aa1d91 
This will automatically remove duplicate dictionary keys with the
`--remove-duplicate-keys` argument.

Closes PyCQA#27
andrewda added a commit to andrewda/autoflake that referenced this issue Jan 3, 2018
@andrewda
Remove duplicate dictionary keys
3275242 
This will automatically remove duplicate dictionary keys with the
`--remove-duplicate-keys` argument.

Closes PyCQA#27
andrewda added a commit to andrewda/autoflake that referenced this issue Jan 3, 2018
@andrewda
Remove duplicate dictionary keys
60edd2b 
This will automatically remove duplicate dictionary keys with the
`--remove-duplicate-keys` argument.

Closes PyCQA#27
andrewda added a commit to andrewda/autoflake that referenced this issue Jan 3, 2018
@andrewda
Remove duplicate dictionary keys
5ded655 
This will automatically remove duplicate dictionary keys with the
`--remove-duplicate-keys` argument.

Closes PyCQA#27
andrewda added a commit to andrewda/autoflake that referenced this issue Jan 3, 2018
@andrewda
Remove duplicate dictionary keys
2de59b7 
This will automatically remove duplicate dictionary keys with the
`--remove-duplicate-keys` argument.

Closes PyCQA#27
andrewda added a commit to andrewda/autoflake that referenced this issue Jan 3, 2018
@andrewda
Remove duplicate dictionary keys
917ff27 
This will automatically remove duplicate dictionary keys with the
`--remove-duplicate-keys` argument.

Closes PyCQA#27
andrewda added a commit to andrewda/autoflake that referenced this issue Jan 3, 2018
@andrewda
Remove duplicate dictionary keys
51f52c9 
This will automatically remove duplicate dictionary keys with the
`--remove-duplicate-keys` argument.

Closes PyCQA#27
andrewda added a commit to andrewda/autoflake that referenced this issue Jan 3, 2018
@andrewda
Remove duplicate dictionary keys
1f04a5e 
This will automatically remove duplicate dictionary keys with the
`--remove-duplicate-keys` argument.

Closes PyCQA#27
andrewda added a commit to andrewda/autoflake that referenced this issue Jan 3, 2018
@andrewda
Remove duplicate dictionary keys
5cd2b3d 
This will automatically remove duplicate dictionary keys with the
`--remove-duplicate-keys` argument.

Closes PyCQA#27
andrewda added a commit to andrewda/autoflake that referenced this issue Jan 3, 2018
@andrewda
Remove duplicate dictionary keys
e35b515 
This will automatically remove duplicate dictionary keys with the
`--remove-duplicate-keys` argument.

Closes PyCQA#27
andrewda added a commit to andrewda/autoflake that referenced this issue Jan 3, 2018
@andrewda
Remove duplicate dictionary keys
4573c58 
This will automatically remove duplicate dictionary keys with the
`--remove-duplicate-keys` argument.

Closes PyCQA#27
@myint myint closed this as completed in #28 Jan 3, 2018
myint pushed a commit that referenced this issue Jan 3, 2018
@andrewda @myint
Remove duplicate dictionary keys (#28)
f7e8fc9 
* Add AUTOFLAKE_COVERAGE env variable

* Add coverage combining

* Run coverage in branch and parallel mode

* Remove duplicate dictionary keys

This will automatically remove duplicate dictionary keys with the
`--remove-duplicate-keys` argument.

Closes #27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement gci
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove duplicate dictionary keys andrewda/autoflake
2 participants
@jayvdb @myint