Skip to content

Commit

Permalink
Fixed #1777: extend_skip is not honored wit a git submodule when skip…
Browse files Browse the repository at this point in the history
…_gitignore=true.
  • Loading branch information
timothycrosley committed Jul 29, 2021
1 parent 6edce90 commit 4d50ebd
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ Find out more about isort's release policy [here](https://pycqa.github.io/isort/
- Fixed #1779: Pylama integration ignores pylama specific isort config overrides.
- Fixed #1781: `--from-first` CLI flag shouldn't take any arguments.
- Fixed #1792: Sorting literals sometimes ignored when placed on first few lines of file.
- Fixed #1777: extend_skip is not honored wit a git submodule when skip_gitignore=true.

### 5.9.2 July 8th 2021
- Improved behavior of `isort --check --atomic` against Cython files.
Expand Down
2 changes: 1 addition & 1 deletion isort/settings.py
Original file line number Diff line number Diff line change
Expand Up @@ -559,7 +559,7 @@ def _check_folder_gitignore(self, folder: str) -> Optional[Path]:
git_options = ["-C", str(git_folder), "-c", "core.quotePath="]
try:
ignored = subprocess.check_output( # nosec # skipcq: PYL-W1510
["git", *git_options, "check-ignore", "-z", "--stdin"],
["git", *git_options, "check-ignore", "-z", "--stdin", "--no-index"],
encoding="utf-8",
env=env,
input="\0".join(files),
Expand Down

0 comments on commit 4d50ebd

Please sign in to comment.