Black profile: enable magic comma#2236
Merged
staticdev merged 1 commit intoPyCQA:mainfrom Jan 17, 2025
Merged
Conversation
barrelful
approved these changes
Jan 17, 2025
staticdev
approved these changes
Jan 17, 2025
aholmes
added a commit
to uclahs-cds/Ligare
that referenced
this pull request
Jan 29, 2025
…`isort` The PR PyCQA/isort#2236 changes default behavior and breaks compatibility with `ruff` (and probably `black`?) `ruff` documentation here: https://docs.astral.sh/ruff/settings/#lint_isort_split-on-trailing-comma
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
blackencounters a trailing comma in thefrom ... importlist, it expands it vertically. Currently,isort --profile=blackdoesn't do that, which confuses people (including me :)), see #2128.This PR enables
split_on_trailing_comma, which is the default Black's behavior.I wasn't sure if I should create a new changelog version header, so i omitted it, since that would require deciding whether this is PATCH or MINOR.
What Black does:
What isort does currently:
After this change: