Recognize abc.ABCMeta as a metaclass base type (#121)

Recognize abc.ABCMeta as a metaclass base type

src/pep8ext_naming.py

@@ -17,6 +17,8 @@
 PYTHON_VERSION = sys.version_info[:3]
 PY2 = PYTHON_VERSION[0] == 2
 
+METACLASS_BASES = frozenset(('type', 'ABCMeta'))
+
 # Node types which may contain class methods
 METHOD_CONTAINER_NODES = {ast.If, ast.While, ast.For, ast.With}
 FUNC_NODES = (ast.FunctionDef,)
@@ -204,7 +206,8 @@ def tag_class_functions(self, cls_node):
         cls_bases = [b for b in cls_node.bases if isinstance(b, ast.Name)]
         # If this class inherits from `type`, it's a metaclass, and we'll
         # consider all of it's methods to be classmethods.
-        ismetaclass = any(name for name in cls_bases if name.id == 'type')
+        ismetaclass = any(
+            name for name in cls_bases if name.id in METACLASS_BASES)
         self.set_function_nodes_types(
             iter_child_nodes(cls_node), ismetaclass, late_decoration)
 

testsuite/N804.py

@@ -1,3 +1,5 @@
+from abc import ABCMeta
+
 #: N804:7:13
 class Foo(object):
     @classmethod
@@ -27,6 +29,9 @@ def __new__(self, name, bases, attrs):
 class MetaMethod(type):
     def test(cls):
         pass
+class MetaMethod(ABCMeta):
+    def test(cls):
+        pass
 #: Okay
 class NotMeta(object):
     otherclass = Foo

testsuite/N805.py

@@ -1,3 +1,5 @@
+from abc import ABCMeta
+
 #: Okay
 class C:
     def __init__(*args, **kwargs):
@@ -46,6 +48,12 @@ def __new__(cls, name, bases, attrs):
         pass
     def test(cls):
         pass
+#: Okay
+class Meta(ABCMeta):
+    def __new__(cls, name, bases, attrs):
+        pass
+    def test(cls):
+        pass
 #: Okay(--classmethod-decorators=clazzy,cool)
 class NewClassmethodDecorators(object):
     @clazzy