Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow camelCase for python standard libraries. #6

Closed
remcohaszing opened this issue Sep 1, 2013 · 10 comments · Fixed by #19
Closed

Allow camelCase for python standard libraries. #6

remcohaszing opened this issue Sep 1, 2013 · 10 comments · Fixed by #19

Comments

@remcohaszing
Copy link

(Unfortunately) some libraries in the python standard library do not follow pep8. This means that people using them are forced to write non pep8-compliant code. This code should be accepted by the pep8-naming plugin.
For example unittest.TestCase is meant to be overridden so setUp and tearDown can be implemented. The same goes for logging.Logger.

@charlax
Copy link

charlax commented Jan 19, 2014

👍

@matthewrankin
Copy link

A current workaround is to add # noqa to the end of camelCased function definitions such as:

def setUp(self):  # noqa

adrianmoisey pushed a commit to adrianmoisey/lint-review that referenced this issue Sep 4, 2014
It seems more pain then it's worth:
PyCQA/pep8-naming#6
PyCQA/pep8-naming#14
@brianpeiris
Copy link

+1

adamcik referenced this issue in adamcik/mopidy Dec 21, 2014
The caller should know what URI we are talking about. Additionally finding the
mtime is never belonged in this class and has been moved out.
@sigmavirus24
Copy link
Member

@lensvol feel free to try to fix this.

@staeff
Copy link

staeff commented May 27, 2015

+1

@sigmavirus24
Copy link
Member

@staeff care to submit a fix?

@staeff
Copy link

staeff commented May 27, 2015

@sigmavirus24 I'll look into it, but can't promise anything. I just came across this issue, when I was researching the problem.

@sigmavirus24
Copy link
Member

@staeff then please understand that adding a +1 to a known issue that the maintainers are willing to accept a patch for is patently unhelpful.

@staeff
Copy link

staeff commented May 27, 2015

@sigmavirus24 oops, sorry.

@sigmavirus24
Copy link
Member

No worries.

gforcada added a commit to gforcada/pep8-naming that referenced this issue May 28, 2015
This configuration option allows to skip certain function names.

This fixes PyCQA#6
gforcada added a commit to gforcada/pep8-naming that referenced this issue May 28, 2015
This configuration option allows to skip certain function names.

This fixes PyCQA#6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants