Avoid stack exhaustion in superclass_names() #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jparise
changed the title
jparise
changed the title
|
Is it worth adding a test to show this doesn't break? |
Because this function is recursive, it can exhaust the stack if the class hierarchy contains duplicate names. Avoid that using simple memoization. Also, these two supporting functions can be classmethods because they don't use any instance-level state.
jparise
force-pushed
the
superclass_names
branch
from
cb91bd7
to
d3cdb47
Compare
Yes, I had one locally that I forgot to include. It's there now. |
sigmavirus24
approved these changes
Aug 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because this function is recursive, it can exhaust the stack if the
class hierarchy contains duplicate names. Avoid that using simple
memoization.
Also, these two supporting functions can be classmethods because they
don't use any instance-level state.
Fixes #174