Fix Issue 218: ignore-names globbing is not case-sensitive on Windows #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malsyned
changed the title
jparise
approved these changes
Oct 21, 2023
There was a problem hiding this comment.
This looks good to me. Thanks for the fix and test improvements!
This resulting behavior is technically backwards-incompatible, but it seems unlike that people were relying on the previous case-insensitive behavior, and those folks can add more case variants to their ignored-names list after they upgrade to this change.
Still, I think it will be worth bumping the minor version for this change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created this branch to fix issue #218. While I was updating the unit tests, I found a couple of tests for N807(--ignore-names) that would have passed regardless of whether that option was included, so this PR also includes a commit that fixes those tests.
The tests that I wrote as part of this fix would only fail on Windows without the fix -- I don't see an easy way to write tests that would fail on all platforms without the fix, but I'm open to suggestions.