Allow one-line hunks in --diff #127
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Git diff, hunks containing only one line in either the original
or modified file do not have the number of lines specified.
Without this patch, pep8 crashes on a diff with such a hunk.
For example, this would fail in pep8's repository:
git show 6ff543b -U0 | pep8 --diff
The -U0 option is useful to only check new code, not anything that
surrounds it. The bug can also appear without -U0, in one-line files.
gthb
referenced
this pull request
in gthb/pep8
Nov 8, 2012
Without this fix, pep8 --diff fails uncleanly on diff hunks where either the old or the new hunk is just one line and the patch omits the `,1` Compact fix for jcrocholl#127
|
Thank you, fixed in issue #137 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Git diff, hunks containing only one line in either the original
or modified file do not have the number of lines specified.
Without this patch, pep8 crashes on a diff with such a hunk.
For example, this would fail in pep8's repository:
git show 6ff543b -U0 | pep8 --diff
The -U0 option is useful to only check new code, not anything that
surrounds it. The bug can also appear without -U0 in one-line files.