Support for custom indent sizes (tab widths) other than 4 #524
Conversation
First step on getting PyCQA#206 merged into master. Next steps: - New tests for strange indents - Fix help string for to be more useful to users - Fix the documentation to account for the new cli input
First step on getting PyCQA#206 merged into master. Next steps: - New tests for strange indents - Fix help string for to be more useful to users - Fix the documentation to account for the new cli input
Test that setting the indent_size to something other than 4 actually works and gives us correct Errors
(Related to a comment on the original pull request) Also, updated docs/intro.rst with the new command
|
I am really interested in seeing this merged. Is anyone planning on merging this? |
|
@iamaspacecow I proposed a PR on your fork with a rebase on PyCQA/pycodestyle master branch. Hope that helps. |
|
@sigmavirus24 as @iamaspacecow is showing no sign of life, should I open a new PR with my branch (rebased on master)? |
|
@tgy this branch does not need to be rebased. @iamaspacecow is not the blocker here. |
|
What do you think about obtaining the indent size from a project's |
|
@jdufresne to whom is your question directed to? |
|
To all involved. To anyone interested in discussing or implementing the idea. |
|
@jdufresne I personally love the idea! |
|
+1 - thanks for this. I have a project with 500,000 SLOC of python that was started long before PEP8 and uses a 3 space indent. |
|
Necromancy +1 :) |
|
how many centuries needed to merge this PR?!! |
|
I'd put a +1 here, but I'll put a -2 because I personally believe that 4 spaces indent is too much. |
|
superseded by #970 |
Updates #206 so that it can be merged with current master
Also, adds unit tests and updates the docs properly