Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for custom indent sizes (tab widths) other than 4 #206

Closed
wants to merge 1 commit into from

Conversation

jansel
Copy link

@jansel jansel commented Jun 8, 2013

No description provided.

@myint
Copy link
Member

myint commented Jul 4, 2013

This seems somewhat undesirable since it explicitly goes against PEP 8. But it does resolve #204 (another issue caused by using pep8 to check explicitly non-PEP-8 code).

@jansel
Copy link
Author

jansel commented Jul 4, 2013

PEP 8 contains an exception for legacy 8-spaced code. This commit would allow that code to be supported properly, so I don't think it goes against PEP 8. Compared to the --max-line-length option I think this is a reasonable change. Setting --max-line-length to a value other than 79 would also violate PEP 8, but it is a common variable in the PEP 8 standard which people change in practice.

However I will admit my personal motivation of this change is for checking 2-spaced code. :)

@mgood
Copy link

mgood commented Aug 20, 2013

+1

We also have an internal style guide that requires 2 spaces for indentation, so it would be nice to have this option when using the PEP8 checking. For now I just have to disable E111 and have no indentation checking.

@rfportilla
Copy link

+1

I don't have control over company policies. I would rather be able to modify the rule instead of ignore it.

ArgentFalcon added a commit to ArgentFalcon/pycodestyle that referenced this pull request Jun 2, 2016
First step on getting PyCQA#206 merged into master.
Next steps:
 - New tests for strange indents
 - Fix help string for  to be more useful to users
 - Fix the documentation to account for the new cli input
ArgentFalcon added a commit to ArgentFalcon/pycodestyle that referenced this pull request Jun 2, 2016
First step on getting PyCQA#206 merged into master.
Next steps:
  - New tests for strange indents
  - Fix help string for  to be more useful to users
  - Fix the documentation to account for the new cli input
tgy pushed a commit to tgy/pycodestyle that referenced this pull request Jan 18, 2017
First step on getting PyCQA#206 merged into master.
Next steps:
 - New tests for strange indents
 - Fix help string for  to be more useful to users
 - Fix the documentation to account for the new cli input
@ghost
Copy link

ghost commented Apr 11, 2018

@jansel writes:

"However I will admit my personal motivation of this change is for checking 2-spaced code. :)"

...and for 3-spaced code. I just too stubborn to use anything else. :)

@jansel
Copy link
Author

jansel commented Apr 11, 2018

Replaced by #524

@jansel jansel closed this Apr 11, 2018
bukzor pushed a commit to bukzor/pycodestyle that referenced this pull request Nov 18, 2020
This is an updated revision of pull requests PyCQA#206 and PyCQA#524
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants