Skip to content
This repository has been archived by the owner on Nov 3, 2023. It is now read-only.

Test on Python 3.9-dev #509

Merged
merged 2 commits into from Aug 30, 2020
Merged

Test on Python 3.9-dev #509

merged 2 commits into from Aug 30, 2020

Conversation

hugovk
Copy link
Contributor

@hugovk hugovk commented Aug 30, 2020

Python 3.9 is out in October, with rc1 now available, and it's strongly recommended to test against it now to make sure libraries work, and also to help test 3.9 itself.

There was an error running mypy:

py39 run-test: commands[1] | mypy --config-file=tox.ini src/
src/pydocstyle/utils.py:25: error: syntax error in type comment
Found 1 error in 1 file (checked 35 source files)
ERROR: InvocationError for command /private/tmp/pydocstyle/.tox/py39/bin/mypy --config-file=tox.ini src/ (exited with code 2)

This looks like it was fixed in mypy in python/mypy#8716, and released in mypy v0.780. So let's upgrade to use the newest 0.782.


Thanks for submitting a PR!

Please make sure to check for the following items:

  • Add unit tests and integration tests where applicable.
    If you've added an error code or changed an error code behavior,
    you should probably add or change a test case file under tests/test_cases/ and add
    it to the list under tests/test_definitions.py.
    If you've added or changed a command line option,
    you should probably add or change a test in tests/test_integration.py.
  • [n/a?] Add a line to the release notes (docs/release_notes.rst) under "Current Development Version".
    Make sure to include the PR number after you open and get one.

Please don't get discouraged as it may take a while to get a review.

@samj1912 samj1912 self-requested a review August 30, 2020 20:54
Copy link
Member

@samj1912 samj1912 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@samj1912 samj1912 merged commit 17a1c64 into PyCQA:master Aug 30, 2020
@hugovk hugovk deleted the add-3.9-dev branch August 30, 2020 21:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants