Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add another test for #422 #433

Merged
merged 2 commits into from
May 4, 2019
Merged

Add another test for #422 #433

merged 2 commits into from
May 4, 2019

Conversation

untitaker
Copy link
Contributor

@untitaker untitaker commented Feb 21, 2019 •
edited

@asottile
Copy link
Member

given there's already a test which covers this regression -- is there benefit for two?

@untitaker
Copy link
Contributor Author

idk if this goes through a different codepath or not, feel free to close

@asottile
Copy link
Member

this is definitely a simpler case of the one I tried to isolate -- in the end it's the same code path though

@untitaker
Copy link
Contributor Author

@asottile do you want me to replace your test or close this?

@asottile
Copy link
Member

replace is probably good 👍

asottile
asottile approved these changes Feb 21, 2019
View reviewed changes
Copy link
Member

@asottile asottile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@myint myint merged commit 0b16364 into PyCQA:master May 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@myint myint myint approved these changes

@asottile asottile asottile approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@untitaker @asottile @myint