Upgraded bootstrap to 2.3.2 via pinax-theme-bootstrap.

[SonOfLilit]

This fixes an issue with open-in-new-tab for firefox.

Longer explanation here:

https://myownfortune.wordpress.com/2013/08/23/165/

I didn't test this.

[dpoirier]

I cannot reproduce the original problem (Firefox 23.0 on Ubuntu Linux 64-bit), but the fix looks pretty safe. I'm going to merge it and deploy to our staging server for a little more testing.

[dpoirier]

@SonOfLilit I have deployed this change to our staging server, on staging-pycon.python.org. Can you verify that it fixes your problem?

And thanks for all the work debugging this and even finding a fix!

[briancurtin]

@SonOfLilit thanks for not only reporting this to pycon-organizers, but for going ahead and finding the code and fixing it yourself :)

[SonOfLilit]

<script src="/2014/site_media/static/bootstrap/js/bootstrap.min.js">
/**
* Bootstrap.js v2.3.1 by @fat & @mdo
* Copyright 2012 Twitter, Inc.
* http://www.apache.org/licenses/LICENSE-2.0.txt
*/

Perhaps you did not pip -r requirements.txt (sorry, don't remember the
exact command for staging)?

On Fri, Aug 30, 2013 at 5:59 PM, Dan Poirier notifications@github.comwrote:

@SonOfLilit https://github.com/SonOfLilit I have deployed this change
to our staging server, on staging-pycon.python.org. Can you verify that
it fixes your problem?

And thanks for all the work debugging this and even finding a fix!

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/206#issuecomment-23566950
.

[SonOfLilit]

And to remove doubt: I also tried to middle click and it failed.

Since Christian Hudon verified that the fix works for him and the unfixed doesn't, perhaps you reverted the change to staging? I cannot think of another explanation.

[dpoirier]

That is what is packaged in https://pypi.python.org/packages/source/p/pinax-theme-bootstrap/pinax-theme-bootstrap-3.0a11.tar.gz. Seems like a packaging bug in pinax_theme_bootstrap.

[dpoirier]

Actually, looking at the commits on pinax_theme_bootstrap, it looks like they upgraded Bootstrap after 3.0a11 and have not yet released 3.0a12.

[dpoirier]

Asked for a new release of pinax_theme_bootstrap in pinax/pinax-theme-bootstrap#62

[SonOfLilit]

Embarassing :-)

I looked at their master and saw it was there, I saw you're not running
latest, and I skipped to wrong conclusions.

On Fri, Aug 30, 2013 at 6:57 PM, Dan Poirier notifications@github.comwrote:

Asked for a new release of pinax_theme_bootstrap in
pinax/pinax-theme-bootstrap#62pinax/pinax-theme-bootstrap#62

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/206#issuecomment-23571071
.

[dpoirier]

3.0a12 is published. I opened a new PR #208 to update to it.