-
-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for MDTM command in FTPFS #462
Conversation
Not sure how I would add tests for this. Are there any tests that run with an actual FTP server? Should I do extensive mocking to simulate a server that supports MDTM? |
I added a test to |
A new namespace "modified" was introduced to the `getinfo` function to potentially use cheaper commands compared to the general "details" namespace. In particular, `FTPFS` now uses the MDTM command if supported by the server.
A new namespace "modified" was introduced to the `getinfo` function to potentially use cheaper commands compared to the general "details" namespace. In particular, `FTPFS` now uses the MDTM command if supported by the server.
# Conflicts: # tests/test_memoryfs.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! A few fixes here and there, but the global structure is as intended 😄
Hi. Any update on this? |
@atollk : sorry for the delay, I had a very intense month but I have a bit more time now. I changed the current implementation a bit because the Instead, I kept the |
@atollk : All clear now. I'll leave you time to object if there is anything to change, ping me when you're done reading and I'll merge. |
Except for that one comment I made it looks good to me 👍 |
Perfect, merging then! Sorry for the delay. |
Type of changes
Checklist
Description
Fixes #456
Added a
getmodified
function tofs.base.FS
which defaults to callinggetinfo
. InFTPFS
, a check for the support ofMDTM
was added to provide a more efficient command for this specialized request.Two calls to
FS.getinfo(...).modified
infs.copy
were replaced by calls toFS.getmodified
.